New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737157 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 705677

Blocking:
issue 589673
issue 705677



Sign in to add a comment

Get better logging to explain TKO update failures

Reported by jrbarnette@chromium.org, Jun 27 2017

Issue description

From time-to-time, we see tests fail because the TKO doesn't
get updated, as described in bug 589673.

Nominally, there are three theories for why that bug might be
happening:
 1) Parsing makes updates in the TKO, and CloudSQL silently
    drops them without signaling an error.
 2) Parsing is somehow ignoring errors during updates.
 3) Parsing is failing to make the updates at all.

We need to add log messages to parsing sufficient to distinguish
the three cases, so that we can make progress on addressing the
core bug.

 
Blocking: 589673
Cc: pho...@chromium.org pprabhu@chromium.org ayatane@chromium.org
that, or metrics on tko failures.
Blockedon: 705677
At a higher level, the ask here is "whatever it takes to add
information that will move bug 589673 further down the field."

Owner: dshi@chromium.org
dshi to add read-back of tko inside of tko/parse to rule out mysql silently dropping transactions
Labels: -Chase-Pending Chase
note for follow-up: after ^ we should ensure that scheduler determine's tko/parse return code and treats non-zero return codes appropriately
Blocking: 705677
CL coming this week.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b0af621a3eda3d41b49db01f0f38f557fab9956a

commit b0af621a3eda3d41b49db01f0f38f557fab9956a
Author: Dan Shi <dshi@google.com>
Date: Wed Jul 19 08:23:39 2017

[autotest] Read tko tests from database after it's saved.

This is to confirm the CloudSQL instance has tko data saved.

BUG= chromium:737157 
TEST=local run tests

Change-Id: Ibe3547363f2bd2ae9d590c95949e3f296827bdca
Reviewed-on: https://chromium-review.googlesource.com/575436
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Dan Shi <dshi@google.com>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/b0af621a3eda3d41b49db01f0f38f557fab9956a/tko/db.py
[modify] https://crrev.com/b0af621a3eda3d41b49db01f0f38f557fab9956a/tko/parse.py

Status: Fixed (was: Available)

Sign in to add a comment