New issue
Advanced search Search tips

Issue 737155 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 618368



Sign in to add a comment

Drop overlays when player's frame is hidden.

Project Member Reported by liber...@chromium.org, Jun 27 2017

Issue description

we don't want to hold onto overlays when the player frame is hidden, since they can consume an MDP lane depending on the compositor surface's eOpaque flag.  they also, of course, consume an overlay.

we should signal to AVDA when the frame is hidden, and drop the overlay immediately.

note that the AVDA instance will also be suspended, but the VideoFrames would still refer to the overlay.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28347e73895e16a6eb7b512d1b7e96f39bab9a75

commit 28347e73895e16a6eb7b512d1b7e96f39bab9a75
Author: liberato@chromium.org <liberato@chromium.org>
Date: Tue Jun 27 20:30:13 2017

Make AVDA drop overlays when its frame is hidden.

When the media player's frame is hidden, we want to give up any
overlay that's used by it.  Even though the pipeline will suspend on
Android, the VideoFrames might survive for much longer.

This CL signals AVDA that the frame is hidden, so that it can drop
the overlays.  Note that AVDA::Destroy isn't enough; suspending the
player while the frames are still visible shouldn't do this.

Bug:  737155 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I958fb07fe2a5fb6e7dedd75417875e23fd98e62a
Reviewed-on: https://chromium-review.googlesource.com/550400
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482734}
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/base/overlay_info.h
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/android_video_surface_chooser.h
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/android_video_surface_chooser_impl_unittest.cc
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/avda_picture_buffer_manager.cc
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/avda_picture_buffer_manager.h
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/avda_shared_state.cc
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/avda_shared_state.h
[modify] https://crrev.com/28347e73895e16a6eb7b512d1b7e96f39bab9a75/media/gpu/ipc/common/media_param_traits_macros.h

liberato@, isn't this fixed?
Status: Fixed (was: Started)
yes, thanks!

Sign in to add a comment