New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737153 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

MD Bookmarks Manager: A wrong resize cursor icon is to see when using the divider

Project Member Reported by meh...@chromium.org, Jun 27 2017

Issue description

Chrome Version: Canary 61.0.3142.0 
OS: macOS 10.12.5

What steps will reproduce the problem?
(1) go to chrome://bookmarks
(2) move the divider and take a look at the cursor


What is the expected result? 
It should be the cursor like in the old Bookmarks Manager.

What happens instead?
In Canary it is an arrow.

Please use labels and text to provide additional information.
Screenshots are attached.

Thanks.


 
actual.png
44.6 KB View Download
expected.png
58.3 KB View Download
Labels: -Pri-2 Pri-3
Owner: tsergeant@chromium.org
Status: Assigned (was: Untriaged)
For some reason the old BMM uses 'col-resize' on macOS but 'e-resize' elsewhere. I think it makes sense for us to just use 'col-resize' everywhere.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aad1d965b804500e9c6a1fb82625353f3df8f33

commit 5aad1d965b804500e9c6a1fb82625353f3df8f33
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Jul 05 09:32:01 2017

MD Bookmarks: Always use a two-way arrow cursor for resizing the sidebar

This changes the cursor on the sidebar to 'e-resize' on Windows and
'col-resize' on other platforms, which results in always showing a
two-way arrow.

This matches the behavior of the old bookmark manager on Windows and
Mac, while Linux (Ubuntu, at least) changes from a one-way arrow to
a two-way arrow.

BUG= 737153 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2970793002
Cr-Commit-Position: refs/heads/master@{#484225}

[modify] https://crrev.com/5aad1d965b804500e9c6a1fb82625353f3df8f33/chrome/browser/browser_resources.grd
[modify] https://crrev.com/5aad1d965b804500e9c6a1fb82625353f3df8f33/chrome/browser/resources/md_bookmarks/app.html

Status: Fixed (was: Started)

Sign in to add a comment