Migrate Dart from Rietveld+Github to Gerrit source-of-truth |
||||||||
Issue descriptionDart is one of the largest remaining customers of Rietveld. They have their own Gerrit server at dart-review.googlesource.com. That should become their review host, and dart.googlesource.com should become the source of truth for their repos, potentially with mirroring back to github.com/dart-lang
,
Jun 30 2017
,
Jul 25 2017
Next steps: * Resolve the blocker (creating service account) * Figure out best way to mirror from GoB to GitHub (I'm working on this in parallel but more minds are better) * One-by-one, change source-of-truth from github to gob. This doesn't involve changing the review system immediately, but does mean contributors will have to change their remote origin url * Then add ACLs for code-review label, submit permission, etc to enable gerrit review for folks who opt in * Then add GERRIT_HOST: True to each repo's codereview.settings to change the default This is all high-priority work: codereview.chromium.org will become read-only before the end of Q3 no matter what, and Dart needs to have a solution in place by then. Obviously happy to help as much as I can, but I need to know what pieces require assistance.
,
Jul 25 2017
,
Jul 25 2017
,
Jul 26 2017
,
Jul 27 2017
+local git admins
,
Aug 17 2017
Schedule for switching github.com/dart-lang/sdk over to dart.googlesource.com/sdk is to do this in the last week of August. Other repos will be switched over in the following days. No blockers anticipated except that we haven't decided on the mirroring from GoB to github yet. We want to change the source-of-truth, the review system, and people's remote origin all at the same time, with instructions for how to copy their outstanding CLs from github/rietveld to gob/gerrit (add remote, merge to branch on new remote, cl upload, adding a link in description to the old CL).
,
Aug 17 2017
Schedule for switching github.com/dart-lang/sdk over to dart.googlesource.com/sdk is to do this in the last week of August. Other repos will be switched over in the following days. No blockers anticipated except that we haven't decided on the mirroring from GoB to github yet. We want to change the source-of-truth, the review system, and people's remote origin all at the same time, with instructions for how to copy their outstanding CLs from github/rietveld to gob/gerrit (add remote, merge to branch on new remote, cl upload, adding a link in description to the old CL).
,
Aug 17 2017
,
Aug 30 2017
We anticipate making the switchover early Monday Sep 4 2017, perhaps a day earlier. We will use a cron job to mirror until the better solution is here.
,
Sep 4 2017
The switch has been made. Will wait for reaction for a couple of days, before closing issue and saying Rietveld can be made read-only for our purposes. There is also an issue about all the other repos in github/dart-lang. Gerrit will be enabled on a case-by-case basis, otherwise pull requests are needed. Also waiting on better mirroring solution than the current cron job.
,
Sep 5 2017
Huzzah! As of today I'm back from vacation, so work on finishing the general mirroring system is progressing again. Will have news for you soon.
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d8cfeaa8097900ae890da69206b3d73594cf542a commit d8cfeaa8097900ae890da69206b3d73594cf542a Author: William Hesse <whesse@google.com> Date: Tue Sep 05 20:29:45 2017 Dart: Update the config for the "fetch dart" command. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=737149 Change-Id: I72e65056519338039d02246dcdfdb3e71c980b92 Reviewed-on: https://chromium-review.googlesource.com/649608 Reviewed-by: Emma Söderberg <emso@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: William Hesse <whesse@google.com> [modify] https://crrev.com/d8cfeaa8097900ae890da69206b3d73594cf542a/fetch_configs/dart.py
,
Sep 29 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by whesse@google.com
, Jun 29 2017