New issue
Advanced search Search tips

Issue 737142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DynamicsCompressor channelCount can only be 1 or 2 and channelCountMode cannot be "max"

Project Member Reported by rtoy@chromium.org, Jun 27 2017

Issue description

The webaudio spec issue https://github.com/WebAudio/web-audio-api/issues/906 clarifies the spec so that the DynamicsCompressor channelCount can only be 1 or 2 and throws an error otherwise as explained in https://webaudio.github.io/web-audio-api/#widl-AudioNode-channelCount
 

Comment 1 by rtoy@chromium.org, Jun 27 2017

Summary: DynamicsCompressor channelCount can only be 1 or 2 and channelCountMode cannot be "max" (was: DynamicsCompressor channelCount can only be 1 or 2.)
For this to be consistent, this also means that the channelCountMode cannot be "max" because the implies the channelCount is ignored.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2695285dbd49fc66d940ea08c71e09e9cc5583

commit df2695285dbd49fc66d940ea08c71e09e9cc5583
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Aug 15 21:43:07 2017

channelCount and channelCountMode constraints for DynamicsCompressor

For the DynamicsCompressorNode, the channelCount is constrained to be
one or two.  This implies that channelCountMode cannot be "max".
Implement these constraints.

Test updated to verify these constraints.

This makes DynamicsCompressorNode consistent with StereoPannerNode and
PannerNode which are also limited to supporting only mono and stereo
inputs.

Bug:  737142 
Test: dynamicscompressor.html
Change-Id: Iaf405d40eff2c778e61c95ef54cbba709d54c885
Reviewed-on: https://chromium-review.googlesource.com/550597
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494560}
[modify] https://crrev.com/df2695285dbd49fc66d940ea08c71e09e9cc5583/third_party/WebKit/LayoutTests/webaudio/constructor/dynamicscompressor.html
[modify] https://crrev.com/df2695285dbd49fc66d940ea08c71e09e9cc5583/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/df2695285dbd49fc66d940ea08c71e09e9cc5583/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

Comment 3 by rtoy@chromium.org, Sep 1 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
Patch landed.

Sign in to add a comment