Fix CQ message when a CL changes during the run
Reported by
jrbarnette@chromium.org,
Jun 27 2017
|
|||
Issue description
If a new patchset is uploaded to a CL while the CL is being
processed in the CQ, the CQ will fail to commit the change.
Failing to commit is the correct behavior, but the error
reporting when this happens is simply inadequate. A message
like this gets buried in logs for the CommitQueueCompletion stage:
15:30:59: ERROR: Could not submit yueherngl:*400029:*acf05131
We should do better:
* The logs should state explicitly that the CL changed during
the run.
* The build page (not just the logs), should include the
message.
,
Aug 15 2017
Bonus points: build can update annotation table with a reference to this errant CL as well, saving deputy labor.
,
Aug 16 2017
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d4ee9add7ebfd47713b4bbc737b887d0b8da136d commit d4ee9add7ebfd47713b4bbc737b887d0b8da136d Author: Jacob Kopczynski <jkop@chromium.org> Date: Wed Aug 23 02:05:11 2017 log changed CLs descriptive to log and build page Changes error log to include patch and error's messages. Adds a Buildbot invocation to add the error message and a link to the patch responsible. Fixes a typo in a pair of comments. New behavior is not adequately tested yet. BUG= chromium:737139 TEST=cros_workon_make --test on lumpy; covers old functionality, fails one test which fails on master (commandline_unittest) Change-Id: I1c9ae8f6d0cdfe1c64ededec26b2ad118c03e08a Reviewed-on: https://chromium-review.googlesource.com/617602 Commit-Ready: Jacob Kopczynski <jkop@chromium.org> Tested-by: Jacob Kopczynski <jkop@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/d4ee9add7ebfd47713b4bbc737b887d0b8da136d/cbuildbot/validation_pool.py [modify] https://crrev.com/d4ee9add7ebfd47713b4bbc737b887d0b8da136d/lib/constants.py
,
Aug 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by akes...@chromium.org
, Aug 15 2017Status: Assigned (was: Available)