New issue
Advanced search Search tips

Issue 737122 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

There is no test for is_browser_shortcut in WebKeyboardEvent

Project Member Reported by a...@chromium.org, Jun 27 2017

Issue description

For a while, |is_browser_shortcut| in WebKeyboardEvent was broken ( bug 721384 ). It was always false.

That is now fixed due to a revert of some code that seemed correct and passed review. But that's rather scary, as |is_browser_shortcut| is used in input handling for correct processing of events, and I'm adding even more code that depends on it (bug 709765).

I'm going to try to get a working test for it, to make sure it doesn't regress again, but I may have to punt and give this to the input event owners.
 

Comment 1 by a...@chromium.org, Jun 27 2017

Components: Internals>Input
avi@ any update on this? Are you still working on this?
Status: Assigned (was: Started)
No update. I am not working on this.

Sign in to add a comment