New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737118 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Team-Security-UX
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR interstitial page text is reported as hard to read

Project Member Reported by cjgrant@chromium.org, Jun 27 2017

Issue description

During security review, it was pointed out that warning text on security-related interstitial pages is hard to read.

UX commented that the content resolution may still need to be tweaked (I believe this applies to regular content as well as interstitials).

Josh, assigning to you to close on whether the text size is optimized or not, and if not, to determine how we should adjust content size/resolution.
 
Labels: VR-BBB OS-Android
Cc: joshcarpenter@chromium.org
Owner: mthiesse@chromium.org
I think we can just change the size of the resolution. Michael, can you please take this and follow up with Josh on the right settings?
Components: UI>Browser>Interstitials

Comment 4 by tiborg@chromium.org, Jul 12 2017

Cc: mthiesse@chromium.org
Owner: tiborg@chromium.org

Comment 5 by tiborg@chromium.org, Jul 14 2017

Status: Started (was: Assigned)
Screenshots provided by Tibor of larger type sizes LGTM. I'm waiting to review the APK in headset (need permission to access), but am okay giving this a thumbs up based on the screenshots alone, so long as we can confirm that 1) interstitial contents are not flowing below the page break, and 2) if they are, it is only in a few cases, and that in those cases, users can to scroll the page to view the full contents.

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27b47d19d555fd68fb2d21471d74fdd26990fd75

commit 27b47d19d555fd68fb2d21471d74fdd26990fd75
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Jul 20 21:08:45 2017

[vr] Zoom in pages in VR by ~20%.

Bug:  737118 
Change-Id: Ib14dfb4207a5cf37b173852a6a4fc13c9d13019f
Reviewed-on: https://chromium-review.googlesource.com/575074
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488402}
[modify] https://crrev.com/27b47d19d555fd68fb2d21471d74fdd26990fd75/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Comment 8 by tiborg@chromium.org, Jul 20 2017

Status: Fixed (was: Started)
All pages are zoomed in by ~20% in VR including the interstitial page.

Sign in to add a comment