New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737105 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 720002



Sign in to add a comment

Collapse story.display_name to story.name

Project Member Reported by nedngu...@google.com, Jun 27 2017

Issue description

Now that every story has name, we can remove story.display_name and always use story.name for referring to a story.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db4fac95396ea048e8e6f200d5f451d12fe78924

commit db4fac95396ea048e8e6f200d5f451d12fe78924
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jun 28 15:30:08 2017

Roll src/third_party/catapult/ 8287b2b48..1e5227efc (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8287b2b48ebb..1e5227efcb4d

$ git log 8287b2b48..1e5227efc --date=short --no-merges --format='%ad %ae %s'
2017-06-28 ashleymarie Changing story.display_name references to story.name

Created with:
  roll-dep src/third_party/catapult
BUG= 737105 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I21f538963ece855c1d9743d48bbd1139fc937d68
Reviewed-on: https://chromium-review.googlesource.com/552360
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482995}
[modify] https://crrev.com/db4fac95396ea048e8e6f200d5f451d12fe78924/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ecf8ce13bac04920177549203948765bdb8c456

commit 7ecf8ce13bac04920177549203948765bdb8c456
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jun 28 18:20:32 2017

Roll src/third_party/catapult/ b0300e327..8114d33c7 (3 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b0300e327451..8114d33c7d55

$ git log b0300e327..8114d33c7 --date=short --no-merges --format='%ad %ae %s'
2017-06-28 sullivan Use short url in bisect bugs for docs on addressing regressions.
2017-06-28 ashleymarie One more place to convert display_name to name
2017-06-28 xunjieli Add a telemetry/examples/record_wpr script to run wpr

Created with:
  roll-dep src/third_party/catapult
BUG= 737105 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I55ff6f79af1d3ee3594ddb42d66426df5c5a2a91
Reviewed-on: https://chromium-review.googlesource.com/552858
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483066}
[modify] https://crrev.com/7ecf8ce13bac04920177549203948765bdb8c456/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eb3f1b5f6d7f6b2bd0c1b606e090bf0eee04210

commit 4eb3f1b5f6d7f6b2bd0c1b606e090bf0eee04210
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jul 05 17:51:36 2017

Roll src/third_party/catapult/ 2b92f9cfd..34ef95cb0 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2b92f9cfd78f..34ef95cb09ce

$ git log 2b92f9cfd..34ef95cb0 --date=short --no-merges --format='%ad %ae %s'
2017-07-05 ashleymarie Removing display_name now that all stories have names

Created with:
  roll-dep src/third_party/catapult
BUG= 737105 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I5ac290691885531a0ba5dd3795e783ecf8c5c514
Reviewed-on: https://chromium-review.googlesource.com/559850
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484305}
[modify] https://crrev.com/4eb3f1b5f6d7f6b2bd0c1b606e090bf0eee04210/DEPS

Status: Fixed (was: Assigned)
Woohoo! I'm gonna go ahead and close this one now that display_name is gone!
That's great! \o/
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment