New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737101 link

Starred by 2 users
Status: Fixed
Owner:
charliea@chromium.org
Closed: Aug 6
Cc:
█ nednguyen@chromium.org
█ shrike@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 726505


Sign in to add a comment

Merge power-specific benchmarks into power.desktop and power.mobile

Project Member Reported by charliea@chromium.org, Jun 27 2017 
To move the power benchmarks into alignment with our more focused benchmark strategy, we'd like to collapse all power.* and battor.* benchmarks into two benchmarks: power.desktop and power.mobile.

The main blocker to this is  bug 726505 : most of the existing power.* benchmarks use the legacy method of collecting power measurements via Python rather than BattOr-based measurement. power.desktop and power.mobile will be using only BattOr-based measurement. However, there's currently no way to measure idle wakeups in the new BattOr world.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fcc7798ea53abc15bbf9039cac0eb7f2c5eb3f0

commit 0fcc7798ea53abc15bbf9039cac0eb7f2c5eb3f0
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Tue Apr 24 23:21:11 2018

Add test of animated GIF to power.typical_10_mobile

Add the page
https://en.wikipedia.org/wiki/File:Rotating_earth_(large).gif to the
stories run in power.typical_10_mobile. This tests power usage when an
animated GIF is running slower than chrome's 60fps animation speed.

Bug:  737101 
Change-Id: Ica34e8fb78446a2c61069268a502ac5e031649bc
Reviewed-on: https://chromium-review.googlesource.com/1018200
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553352}
[modify] https://crrev.com/0fcc7798ea53abc15bbf9039cac0eb7f2c5eb3f0/tools/perf/page_sets/data/typical_10_mobile.json
[add] https://crrev.com/0fcc7798ea53abc15bbf9039cac0eb7f2c5eb3f0/tools/perf/page_sets/data/typical_10_mobile_002.wprgo.sha1
[modify] https://crrev.com/0fcc7798ea53abc15bbf9039cac0eb7f2c5eb3f0/tools/perf/page_sets/typical_10_mobile.py
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bc6326b5f1f2b2151c5bf02b025206a69d07341

commit 0bc6326b5f1f2b2151c5bf02b025206a69d07341
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu May 31 21:22:39 2018

Collapse battor.trivial_pages and battor.steady_state into power.desktop

I verified that this works on:

Linux: https://pinpoint-dot-chromeperf.appspot.com/job/12cf5d5a240000
Mac: https://pinpoint-dot-chromeperf.appspot.com/job/12cf5d5a240000
Windows: https://pinpoint-dot-chromeperf.appspot.com/job/14f55a7a240000

BUG= 737101 ,  847918 

Change-Id: I05fd698833db3695f9db4aba0d3549bc5d87c006
Reviewed-on: https://chromium-review.googlesource.com/1076953
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#563378}
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/benchmark.csv
[delete] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/benchmarks/benchmark_smoke_unittest.py
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/benchmarks/power.py
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/core/benchmark_android_bot_map.json
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/core/benchmark_desktop_bot_map.json
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/core/benchmark_sharding_map.json
[modify] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/core/perf_data_generator.py
[rename] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/page_sets/data/desktop_power_stories.json
[add] https://crrev.com/0bc6326b5f1f2b2151c5bf02b025206a69d07341/tools/perf/page_sets/desktop_power.py
[delete] https://crrev.com/88023f28bf27d822eb4c29f657f3ab4c10317f6a/tools/perf/page_sets/idle_after_loading_stories.py

Comment 3 by charliea@chromium.org, Aug 6

Status: Fixed (was: Assigned)
►

Sign in to add a comment