New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737089 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

playground/gerrit-tricium repo inheriting more than it needs from infra/infra

Project Member Reported by emso@chromium.org, Jun 27 2017

Issue description

For some reason submit via CQ appears on my experimental tricium repo,  https://chromium.googlesource.com/playground/gerrit-tricium. I got a warning about the infra project having CQ enabled when I was submitting https://chromium-review.googlesource.com/c/549325/
 
Components: -Infra>CQ Infra>Codereview>Gerrit
i think this is default now, and you have to opt out. This has nothing to do with cq though, but gerrit label config and chumpdetector.

Comment 2 by aga...@chromium.org, Jun 27 2017

Cc: aga...@chromium.org
Components: -Infra>Codereview>Gerrit Infra>Git>Admin
Owner: emso@chromium.org
Status: Assigned (was: Untriaged)
Summary: playground/gerrit-tricium repo inheriting more than it needs from infra/infra (was: CQ mysteriously enabled for new project)
You set your repo to inherit settings from infra/infra (which you shouldn't do, btw -- only inherit from "parent" projects like infra, not "leaf" projects like infra/infra). That means that you get all the same settings as your parent project: same labels, same plugin configs, everything. So you have the CQ label, and you have chumpdetector telling you to not to skip the CQ.

There are a few appropriate fixes here:
1) Make it inherit from infra, and then add config to your leaf project to disable the CQ label and chumpdetector (I can show you how to do this if you like)
2) Make it inherit from infra, and give it a real CQ
3) Make it inherit from something else appropriately experimental, like the 'playground' parent repo, and then just add the ACLs you need

As a git admin, I'll leave the resolution up to you :)

Comment 3 by emso@chromium.org, Jun 28 2017

Thanks! New area for me and I didn't set this up. I'll poke around in there and probably go for option 3 :)

Comment 4 by emso@chromium.org, Jun 28 2017

After more consideration, I'll go with option 1. How do I disable the CQ label?

Comment 5 by aga...@chromium.org, Jun 28 2017

Disable the CQ label with a change like this: https://chromium.googlesource.com/infra/gerrit-plugins/+/6ebbf202f7e81cc2d016e235fbd20f0978d6508c

Disable the chumpdetector from complaining about you not using the CQ with a file like this:
https://chromium.googlesource.com/infra/gerrit-plugins/+/c36fec2133d174125325e00c3c95ed911a4326f2/chumpdetector.config

Comment 7 by emso@chromium.org, Jun 30 2017

Edited project.config via https://chromium-review.googlesource.com/c/557801/ didn't manage to checkout refs/meta/config on a local branch. How do I get this setup?

Comment 8 by aga...@chromium.org, Jun 30 2017

$ mkdir /tmp/meta/myrepo
$ cd /tmp/meta/myrepo
$ git init
$ git remote add origin https://chromium.googlesource.com/myrepo
$ git config remote.origin.fetch +refs/meta/config:refs/remotes/origin/refs/meta/config
$ git fetch origin
$ git checkout origin/refs/meta/config
$ # edit and commit
$ git push origin HEAD:refs/for/refs/meta/config

Comment 9 by emso@chromium.org, Aug 15 2017

Thanks Aaron!

Comment 10 by emso@chromium.org, Aug 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment