New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737081 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Jul 2017
Cc:
calamity@chromium.org
pnangunoori@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

MD Bookmarks: Toast 'undo' button should be removed from tab order when offscreen

Reported by dchau...@etouch.net, Jun 27 2017 
Chrome Version: 61.0.3141.0 (Official Build)180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153} 32/64-bit.
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3).

Pre-condition: Bookmark 5-6 webpages such that bookmark entry gets created on chrome://bookmarks page.

What steps will reproduce the problem?
1. Launch chrome and navigate chrome://bookmarks page.
2. Press 'Tab' key till focus reaches to three dot icon of first bookmarked URL.
3. Again once press the 'Tab' key from keyboard and observe the focus.
4. Now, press 'Enter' key from keyboard and observe the bookmarked URLs.

Actual:
1. After step 3: Focus gets lost on pressing 'Tab' key.
2. After step 4: Unnecessary bookmarked entry gets deleted on pressing 'Enter' key from keyboard.

Expected:
1. After step 3: Focus should move to 'View site information' in omnibox on pressing 'Tab' key.
2. After step 4: Bookmarked entry should not get deleted on pressing 'Enter' key from keyboard.

This is a regression issue, broken in M-61 series, below is manual regression range.

Good build: 61.0.3123.0
Bad build: 61.0.3124.0

Note: To reproduce the issue in 'Good build' and 'Bad build', enable "Enable Material Design bookmarks" flags from chrome://flags

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
1.8 MB View Download
Expected behavior.mp4
694 KB View Download

Comment 1 by pnangunoori@chromium.org, Jun 27 2017

Cc: pnangunoori@chromium.org
Labels: hasbisect-per-revision
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3123.0(Revision:477506).
Bad build:61.0.3124.0(Revision:477839).
You are probably looking for a change made after 477563 (known good), but no later than 477564 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/121fec7bb384638df1cc3e26fda0bed886970a38..efe47735cb33458311b6d71a3ff47ff65f4200e8


From the CL above, assigning the issue to the owner concerned

@calamity: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned.

Review-Url:https://codereview.chromium.org/2898303004 

Note :Able to reproduce the issue in Win 10,Ubuntu 14.04 & Mac 10.12.5 and able to reproduce in latest Canary #61.0.3141.0

Comment 2 by calamity@chromium.org, Jun 28 2017

Cc: calamity@chromium.org
Owner: tsergeant@chromium.org

Comment 3 by tsergeant@chromium.org, Jun 28 2017

Labels: Proj-MaterialDesign-WebUI
Summary: MD Bookmarks: Toast 'undo' button should be removed from tab order when offscreen (was: Regression: Unnecessary bookmarked entry gets deleted on pressing 'Enter' key.)

Comment 4 by tsergeant@chromium.org, Jul 4 2017

Status: Fixed (was: Assigned)
I forgot to tag the CL, but this was fixed in R483955.
►

Sign in to add a comment