New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737076 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Jul 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 658980



Sign in to add a comment

Regression:After hitting backspace button background bookmark entry appears in chrome://bookmarks

Reported by vku...@etouch.net, Jun 27 2017 
Chrome Version:61.0.3141.0 (Official Build)180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153} (32/64 Bit)
OS:Windows (7,8,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

Pre condition : Enable Material Design bookmarks flag from chrome://Flags. 

What steps will reproduce the problem?
(1)Launch chrome bookmark 2-3 webpages and navigate to chrome://bookmarks/
(2)Enter long invalid data in search field and hit backspace button to delete text.
(3)Observe the content of page while deleting text.

Actual: After hitting backspace button background bookmark entry appears.

Expected: Background bookmark entry should not appear after hitting backspace button.

This is a regression issue broken in 'M59' and below is the manual regression range
Good Build:  59.0.3068.1
Bad Build:   59.0.3069.0
Actual_bookmark.mov
4.6 MB Download
Expected_bookmark.mov
2.9 MB Download

Comment 1 by kkaluri@chromium.org, Jun 27 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 59.0.3068.1,  Revision Range - 463474
Bad build  : 59.0.3069.0,  Revision Range - 463921

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/7b30725259fd3886adc458795222dc1ee600f88e..b466a02f6480a6f2823b823fc69f4f693377863e

From the above CL suspecting the below change
---------------------------
Review-Url: https://codereview.chromium.org/2812493002

tsergeant@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by tsergeant@chromium.org, Jun 28 2017

Labels: Proj-MaterialDesign-WebUI

Comment 3 by tsergeant@chromium.org, Jul 6 2017

Blocking: 658980
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca6bd61910347a8d6b53299b2a621c312aed7129

commit ca6bd61910347a8d6b53299b2a621c312aed7129
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jul 06 08:21:15 2017

MD Bookmarks: Prevent flash of folder contents when changing search term

In MD Bookmarks, changing search term would clear the results of the
current search, then fire off a new search request, which would bring in
new results <1 second later. This caused a brief flash of folder contents
for whatever folder was currently selected.

This CL fixes that issue by holding on to the old search results until
the new search results are available.

BUG= 737076 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2972963003
Cr-Commit-Position: refs/heads/master@{#484494}

[modify] https://crrev.com/ca6bd61910347a8d6b53299b2a621c312aed7129/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/ca6bd61910347a8d6b53299b2a621c312aed7129/chrome/browser/resources/md_bookmarks/types.js
[modify] https://crrev.com/ca6bd61910347a8d6b53299b2a621c312aed7129/chrome/browser/resources/md_bookmarks/util.js
[modify] https://crrev.com/ca6bd61910347a8d6b53299b2a621c312aed7129/chrome/test/data/webui/md_bookmarks/reducers_test.js

Comment 5 by tsergeant@chromium.org, Jul 6 2017

Status: Fixed (was: Started)

Comment 6 by vku...@etouch.net, Jul 11 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3153.0 TE-Verified-61.0.3153.4
Note: Above issue is fixed on latest Dev version 61.0.3153.0 for Win and 61.0.3153.4 for Mac, Linux OS
►

Sign in to add a comment