New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737072 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to remove app from chrome://apps

Reported by aiman.an...@etouch.net, Jun 27 2017

Issue description

Chrome Version: 61.0.3142.0 (Official Build) (cohort: 59_115_Win)58a8bea874fcfa2c18749645f087d0b21b8a21a0-refs/heads/master@{#482491}(32/64-bit).

OS: Windows(7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6).

Steps to reproduce:
1) Launch chrome, go to chrome://apps, remove one app and try to remove another app.

Actual Result: Unable to remove app from chrome://apps on second instance.
Expected Result: Should be able to remove app from chrome://apps.

This is regression issue broken in M-61, and will soon update the bisect info.

Manual Bisect Info:
Good Build: 61.0.3139.0
Bad Build: 61.0.3140.0
 
Actual Result.mp4
588 KB View Download
Expected Result.mp4
537 KB View Download
Note: Able to reproduce the above issue on latest DEV #61.0.3141.0
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Dev
Owner: khmel@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3139.0(Revision:481757).
Bad build:61.0.3140.0(Revision:482096).

You are probably looking for a change made after 481801 (known good), but no later than 481802 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/3a2065e70c18fc516374f011048cca308cf8ffa9..0df82202a267058499e2420cd8ef7c74899092c1

From the CL above, assigning the issue to the concern owner

@khmel: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on:https://chromium-review.googlesource.com/527527
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3142.0
Adding Release Block-Dev for this issue.Please remove if not the case.

Comment 3 by ajha@chromium.org, Jun 27 2017

Cc: kavvaru@chromium.org gov...@chromium.org ligim...@chromium.org

Comment 4 by khmel@chromium.org, Jun 27 2017

Status: Started (was: Assigned)
is this applicable to Chrome OS?

Comment 7 by khmel@chromium.org, Jun 27 2017

No, this is generic code, used everywhere.
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Thanks for providing the fix. 

Not considering this bug as Dev blocker for today's desktop RC - 61.0.3141.7 and 61.0.3141.8 since its not common use case from users perspective.
Just to Update,

Able to reproduce this issue on Mac 10.12.5 with chrome #61.0.3143.0
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67c67c8730fa5b51eb55dca848cbc725d13113d1

commit 67c67c8730fa5b51eb55dca848cbc725d13113d1
Author: khmel <khmel@google.com>
Date: Wed Jun 28 21:48:31 2017

Make all usages of extension uninstall dialog as 'single-use'.

In previous refactoring uninstall dialog was made single time use. Some
code reuses uninstall dialog. This CL makes all usage as single-time
use.

BUG= 737072 
TEST=Manually on device on "chrome://apps" page and could remove
     multiple apps.

Change-Id: I69c952de4fc420edbcd84a5d806c32efc672fa18
Reviewed-on: https://chromium-review.googlesource.com/550256
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#483152}
[modify] https://crrev.com/67c67c8730fa5b51eb55dca848cbc725d13113d1/chrome/browser/extensions/extension_storage_monitor.cc
[modify] https://crrev.com/67c67c8730fa5b51eb55dca848cbc725d13113d1/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/67c67c8730fa5b51eb55dca848cbc725d13113d1/chrome/browser/ui/webui/ntp/app_launcher_handler.h

Labels: TE-Verified-M61 TE-Verified-61.0.3144.0
Tested the issue on Latest Chrome Canary# 61.0.3144.0 on Windows, Mac and Linux and not able to reproduce the issue.
Hence adding TE-Verified labels for the same.
Thank You.

Comment 12 by khmel@chromium.org, Jun 29 2017

Status: Fixed (was: Started)
Thank you for fast verification!

Sign in to add a comment