Issue metadata
Sign in to add a comment
|
1%-32.9% regression in webrtc_perf_tests at 18536:18538 |
||||||||||||||||||||
Issue descriptionA change from gcc to clang in android builds seems to be the reason for some decrease in quality and compression performance. Assosciated roll: https://chromium.googlesource.com/external/webrtc/+/d3d8702bcf8cb263dbda758cd7c00e123cdba791 Suspect commit: https://chromium.googlesource.com/chromium/src/build/+/5a7ba0fdfa1c5c98291d5a66f5d2a085051de215
,
Jun 28 2017
Yes, this has been observed in other bugs as well, the GCC->Clang switch causes this. We could proceed with GCC short term by explicitly setting is_clang=false in our GN builds. Long term, I think we have to move to Clang, since GCC is deprecated in the NDK and will be removed in the future. I'm leaving it to marpan@ / holmer@ to decide what to do.
,
Jun 28 2017
,
Mar 5 2018
Marco, I just found this in my backlog, it must have slipped. Can you look into why this is the case, and if there's something we can do to improve the quality with clang?
,
Mar 5 2018
Issue 733604 has been merged into this issue.
,
Apr 5 2018
Tested on Pixel, built with gcc vs clang in NDK. The clang one runs 6-10% faster than the one built with gcc, depending on resolution and number of threads. I didn't see any regression across several HD and VGA clips on both 1 and 2 threads. And the results of gcc and clang are bit-exact. Close this for now.
,
Apr 5 2018
The test I ran above is standalone libvpx. The clang I used is Android clang version 3.8.256229 (based on LLVM 3.8.256229). The gcc I used is aarch64-linux-android-gcc (GCC) 4.9.x 20150123 (prerelease). |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by srte@chromium.org
, Jun 27 2017