New issue
Advanced search Search tips

Issue 737047 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Web Audio AudioDestination kFIFOSize may need to be increased

Reported by andrew.macpherson@soundtrap.com, Jun 27 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.109 Safari/537.36

Steps to reproduce the problem:
Filing this issue based on a request from hongchan@ in this CL: https://codereview.chromium.org/2908073002/

What is the expected behavior?

What went wrong?
The kFIFOSize in Blink's AudioDestination.cpp probably needs to be bigger since some OSes allow buffer sizes of 8192 via latencyHint now, or else we need to do some validation of the latencyHint 'exact' size before passing it to CreateAudioDevice(). Clamping may be tricky though as the buffer size is dependent on the sample rate for some platforms and we're passing in a time value and not a buffer size in the latencyHint.

Filing this issue based on a comment in a CL here: https://codereview.chromium.org/2908073002/#msg33

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 59.0.3071.109  Channel: n/a
OS Version: OS X 10.12.5
Flash Version:
 
Labels: Needs-Triage-M59

Comment 2 by hdodda@chromium.org, Jun 29 2017

Status: Untriaged (was: Unconfirmed)
Untraiging the issue as per the comment in CL , so that it would get addressed by dev team.

Thanks!
Owner: hongchan@chromium.org
Status: Assigned (was: Untriaged)
Currently the FIFO size is 12,288 (= 96 * 128) so it is bigger than 8192. Should we close this issue now?

Comment 5 by rtoy@chromium.org, Jan 16 2018

Yeah, let's close this; the original TODO comment was removed.
Status: Verified (was: Assigned)

Sign in to add a comment