New issue
Advanced search Search tips

Issue 737046 link

Starred by 1 user
Status: Fixed
Owner:
horo@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 649558



Sign in to add a comment

FetchEvent::OnNavigationPreloadError() should not call PreloadResponseProperty::Reject() if it is not pending.

Project Member Reported by horo@chromium.org, Jun 27 2017 
OnNavigationPreloadError could be called even after the service worker receives the response header.
This happens when the request is canceled after receiving the header.


If this happens, the renderer process crashes at NOTREACHED() in ScriptPromiseProperty.
https://chromium.googlesource.com/chromium/src/+/d90e3bcca9f75282bbf0c17239c022e3124c654e/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h#134
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de0d72da49996b4e2c267e5a154a268e720e58ed

commit de0d72da49996b4e2c267e5a154a268e720e58ed
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Jun 27 09:45:47 2017

Don't call ScriptPromiseProperty::Reject() if it is not pending.

FetchEvent::OnNavigationPreloadError() could be called even after FetchEvent::OnNavigationPreloadResponse() was called.

Bug:  737046 
Change-Id: Iffa616be92b6c4bf33a24cb79e8657b8edf0de30
Reviewed-on: https://chromium-review.googlesource.com/549560
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482585}
[modify] https://crrev.com/de0d72da49996b4e2c267e5a154a268e720e58ed/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Comment 2 by horo@chromium.org, Jun 28 2017

Status: Fixed (was: Assigned)

Comment 3 by falken@chromium.org, Jul 28 2017

Blocking: 649558
Labels: Stability M-61
►

Sign in to add a comment