New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737036 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
jmukthavaram@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary disabled ‘Rename’ & ’Delete’ option in context menu of LHS is working.

Reported by abom...@etouch.net, Jun 27 2017 
Chrome Version:61.0.3141.0 (Official Build)180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153}
OS:Windows (7,8,8.1,10),Mac OS X(10.11.6,10.12.3)

Pre-condition:
1. Enable ‘#enable-md-bookmarks’ flag
2. Bookmark 2-3 website.

What steps will reproduce the problem?
1.Launch chrome and navigate to chrome://bookmarks/?id=1
2.Right click on ‘Bookmark Bar’ option or ‘Other Bookmarks option such that context menu gets open.
3. Click on disabled ’Rename’ option, Observe.
4. Click on disabled ‘Delete’ option, Observe.

Actual:
1.Unnecessary disabled ‘Rename’ dialog box gets open after step 3.
2. Unnecessary disabled ‘Delete’ option works and bubble is displayed.

Expected: Disabled ‘Rename’ & ’Delete’ option in context menu should not work.

This is regression issue, broken in ‘M 61’ and below is manual bisect:
Good build:61.0.3137.0
Bad build:61.0.3138.0
Actual_bookmark.mov
2.0 MB Download
Exp_bookmark.mov
1.5 MB Download

Comment 1 by jmukthavaram@chromium.org, Jun 27 2017

Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.5, Windows 7 using latest Canary#61.0.3141.0.
Manual Bisect:
-------------
Good build:61.0.3137.0-Revision-481056
Bad build:61.0.3138.0-Revision-481386

Per revision bisevt info:
------------------------
You are probably looking for a change made after 481160 (known good), but no later than 481161 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/6faeef0f0300547242c025a122479b7e036d3e46..64e2012a9e0278ff735674d16db1c44caefc91ae

Possible suspect:
---------------
https://chromium.googlesource.com/chromium/src/+/64e2012a9e0278ff735674d16db1c44caefc91ae

Calamity@Could you please take a look and reassign to the right owner if it is not related to your change.

Note: No issue observed on Ubuntu 14.04

Thanks..!!

Comment 2 by jmukthavaram@chromium.org, Jun 27 2017

Labels: Proj-MaterialDesign-WebUI

Comment 3 by jmukthavaram@chromium.org, Jun 27 2017

Labels: OS-Linux
Please ignore note in comment#1.
Issue also reproduced on Ubuntu 14.04 using latest Canary-61.0.3141.0.
Thanks.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ef08e4c5ad81f0f285054df0d705258178c4ede

commit 4ef08e4c5ad81f0f285054df0d705258178c4ede
Author: calamity <calamity@chromium.org>
Date: Thu Jun 29 04:03:26 2017

[MD Bookmarks] Make disabled buttons in context menu do nothing when clicked.

BUG= 737036 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2956213002
Cr-Commit-Position: refs/heads/master@{#483289}

[modify] https://crrev.com/4ef08e4c5ad81f0f285054df0d705258178c4ede/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/4ef08e4c5ad81f0f285054df0d705258178c4ede/chrome/test/data/webui/md_bookmarks/command_manager_test.js

Comment 5 by calamity@chromium.org, Jun 29 2017

Status: Fixed (was: Assigned)

Comment 6 by abom...@etouch.net, Jul 11 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3153.0 TE-Verified-61.0.3153.4
Note: Above issue is fixed on latest Dev version 61.0.3153.0 for Win and 61.0.3153.4 for Mac, Linux OS
►

Sign in to add a comment