New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 737035 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Print preview page does not disappear after clicking on 'Print using system dialog... (Ctrl+Shift+P)'

Reported by nutan.ga...@etouch.net, Jun 27 2017

Issue description

Chrome Version : 61.0.3141.0 180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153}
OS : Windows(7,8,10)

What steps will reproduce the problem?
1. Launch Chrome, navigate to chrome://terms/
2. Press Ctrl + P, and click on 'Print using system dialog... (Ctrl+Shift+P)' on print preview page
3. Observe

Actual: Print preview page does not disappear after clicking on 'Print using system dialog... (Ctrl+Shift+P)' in chrome://terms/ 

Expected: Print preview page should disappear after clicking on 'Print using system dialog... (Ctrl+Shift+P)'

This is a regression issue broken in 'M61' and below is the manual regression range
Good build : 61.0.3139.0
Bad build : 61.0.3140.0 

Note: Issue is not reproducible in Mac and will soon update Linux info.
 
Actual_video.mp4
1.1 MB View Download
Expected_video.mp4
1.1 MB View Download
Summary: Regression: Print preview page does not disappear after clicking on 'Print using system dialog... (Ctrl+Shift+P)' (was: Regression: Print preview page does not disappear after clicking on 'Print using system dialog... (Ctrl+Shift+P)' in chrome://terms/)
Note: Above issue is seen on all web-pages

Thanks.
Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7 using chrome latest Canary-61.0.3141.0.
Manual Bisect:
--------------
Good build : 61.0.3139.0-Revision-481757
Bad build : 61.0.3140.0 -Revision-482096

Per revision bisect info:
-------------------------
You are probably looking for a change made after 482094 (known good), but no later than 482095 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/7e19dfa32df45d1541fde8f76bcf8eb819889c0c..d29fc0d18dc459eb543f50860d7d244694bebc5d

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/d29fc0d18dc459eb543f50860d7d244694bebc5d

Rbpotter@Please look into this issue.

Note: No issue observed on Mac & Ubuntu 14.04.

Thanks.
Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63f156d9c2dfd6a04d1a49a58a1c0178b1e3f6e1

commit 63f156d9c2dfd6a04d1a49a58a1c0178b1e3f6e1
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jun 28 02:30:07 2017

Print Preview: close dialog when system dialog is open (Win)

When the system dialog opens on Windows, this is sent through the normal
print message. However, since the dialog is modal, the promise will not
be resolved until the dialog closes if the message is sent to the
renderer first. Resolve the promise before forwarding settings to the
renderer.

BUG= 737035 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2961863002
Cr-Commit-Position: refs/heads/master@{#482855}

[modify] https://crrev.com/63f156d9c2dfd6a04d1a49a58a1c0178b1e3f6e1/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/63f156d9c2dfd6a04d1a49a58a1c0178b1e3f6e1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/63f156d9c2dfd6a04d1a49a58a1c0178b1e3f6e1/chrome/browser/ui/webui/print_preview/print_preview_handler.h

Labels: TE-Verified-M61 TE-Verified-61.0.3144.0
Tested the issue on Latest Chrome Canary# 61.0.3144.0 on Windows and not able to reproduce the issue.
Hence adding TE-Verified labels for the same.
Thank You.
Status: Fixed (was: Assigned)

Sign in to add a comment