MD Bookmarks: Should not be able to 'sort' an empty folder
Reported by
rp...@etouch.net,
Jun 27 2017
|
||||
Issue descriptionVersion: 61.0.3141.0 180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3) Pre condition : Enable Material Design bookmarks flag from chrome://Flags. What steps will reproduce the problem? 1. Freshly launch chrome and navigate to chrome://bookmarks 2. Now click on 'iron' icon in top RHS of page and click on 'Sort by title' option,observe Actual: Unnecessary 'Folder sorted' message is displayed when there are no folders. Expected: Unnecessary 'Folder sorted' message should not be displayed when there are no folders. This is regression issue, broken in ‘M 61’ and will soon update other info : Good build:61.0.3123.0 Bad build: 61.0.3124.0
,
Jun 27 2017
Using the per-revision bisect providing the bisect results, Good build:61.0.3123.0(Revision:477506). Bad build:61.0.3124.0(Revision:477839). You are probably looking for a change made after 477563 (known good), but no later than 477564 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/121fec7bb384638df1cc3e26fda0bed886970a38..efe47735cb33458311b6d71a3ff47ff65f4200e8 From the CL above, assigning the issue to the concern owner @calamity: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2898303004 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3141.0
,
Jun 28 2017
,
Jul 7 2017
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9256bd64c54c4194f63cc084612536e3e53ae0a commit a9256bd64c54c4194f63cc084612536e3e53ae0a Author: calamity <calamity@chromium.org> Date: Tue Jul 11 08:54:29 2017 [MD Bookmarks] Prevent sorting of empty folders. This CL disables the sort button in the toolbar action menu for empty folders. BUG= 737034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2973783002 Cr-Commit-Position: refs/heads/master@{#485563} [modify] https://crrev.com/a9256bd64c54c4194f63cc084612536e3e53ae0a/chrome/browser/resources/md_bookmarks/toolbar.html [modify] https://crrev.com/a9256bd64c54c4194f63cc084612536e3e53ae0a/chrome/browser/resources/md_bookmarks/toolbar.js [modify] https://crrev.com/a9256bd64c54c4194f63cc084612536e3e53ae0a/chrome/test/data/webui/md_bookmarks/toolbar_test.js
,
Jul 12 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rp...@etouch.net
, Jun 27 2017Labels: Proj-MaterialDesign-WebUI