New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 737030 link

Starred by 1 user
Status: Fixed
Owner:
█ josa...@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
cros-perf-detectives@google.com
cywang@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

adb_cmd should have a parameter for timeout

Project Member Reported by cywang@chromium.org, Jun 27 2017 
In a cheets autotest cheets_BlockOutboundNetworkTest(https://storage.cloud.google.com/chromeos-autotest-results/125178566-chromeos-test/chromeos2-row7-rack10-host19/cheets_BlockOutboundNetworkTest/debug/cheets_BlockOutboundNetworkTest.DEBUG?_ga=1.254724296.1328993051.1494578494), the adb_cmd for uninstalling uiautomator waited forever(I actually killed the adb uninstall manually). Although we know it should be the networking issue, however, we should enforce the timeout of adb_cmd() call.

===
06/26 13:31:41.405 DEBUG|              test:0621| Running cleanup for test.
06/26 13:31:41.406 INFO |               arc:0502| Starting ARC cleanup
06/26 13:31:41.407 INFO |               arc:0632| Uninstalling com.github.uiautomator
06/26 13:31:41.407 DEBUG|             utils:0212| Running 'android-sh -c 'getprop ro.boot.partial_boot''
06/26 13:31:41.477 DEBUG|             utils:0212| Running 'adb get-state'
06/26 13:31:41.493 DEBUG|               arc:0067| adb get-state: device
06/26 13:31:41.494 DEBUG|             utils:0212| Running 'adb uninstall com.github.uiautomator'
06/26 21:31:35.670 DEBUG|          arc_util:0041| ARC is enabled in mode enabled
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/942526e79c935e2469cc9972c136a27e0a40d7db

commit 942526e79c935e2469cc9972c136a27e0a40d7db
Author: Chung-yih Wang <cywang@google.com>
Date: Wed Jun 28 13:54:29 2017

arc.py: Add adb_cmd timeout

BUG= chromium:737030 
TEST=On DUT, use test_that with a adb_cmd('logcat') which lasts longer than
the timeout value and it fails eventually.

Change-Id: Ida5e17cf0d50c421300ebdf1cbd3f9c2641d3fd9
Signed-off-by: Chung-yih Wang <cywang@google.com>
Reviewed-on: https://chromium-review.googlesource.com/549741
Reviewed-by: Shuo-Peng Liao <deanliao@chromium.org>

[modify] https://crrev.com/942526e79c935e2469cc9972c136a27e0a40d7db/client/common_lib/cros/arc.py

Comment 2 by cywang@chromium.org, Jul 3 2017

Cc: cywang@chromium.org
Labels: Merge-Request-60
Owner: josa...@chromium.org
We need this to unblock the job scheduling in test lab for R60 builds as well.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 3 2017

Labels: -Merge-Request-60 Merge-Reject-60 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cywang@chromium.org, Jul 3 2017 

FYI - this won't touch any release code at all.

Comment 5 by abodenha@chromium.org, Jan 26 2018

Status: Fixed (was: Untriaged)
Sounds like this was fixed in tot but left open for the merge request. Since we're long past M60 now I'm closing this. PLease reopen and explain if there is more to do here.
►

Sign in to add a comment