Message in a simple notification is not expanded when expand button is clicked. |
|||||||||
Issue descriptionChrome Version: ToT OS: Chrome What steps will reproduce the problem? (1) Enable --enabled-new-style-notification (2) Show a notification (e.g. from chrome.notifications API) whose message does not fit in one line. (3) Click expand button on the notification. What is the expected result? The message is expanded up to 4 lines. What happens instead? The message stays 1 line. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jul 13 2017
,
Jul 14 2017
Thank you for investigating!
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bd6882a7344b149f5fa8f9c4a4b0d80dadc64e0 commit 9bd6882a7344b149f5fa8f9c4a4b0d80dadc64e0 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jul 25 09:35:06 2017 Fix message expansion bug in MD notification. In MD notification, simple notification was not properly expanded when expand button was clicked. This was caused by a bug BoxLayout does not properly handle a view that use its width to calculate the height such as BoundedLabel (https://crbug.com/682266). We workaround this instead because there's no obvious solution, and the number of affected classes by BoxLayout change is large. The detail is written in the comment. BUG= 736998 TEST=out/Debug/message_center_unittests Change-Id: I2cb5d1e20376e259f1090cbfd03eb55ef55c275b Reviewed-on: https://chromium-review.googlesource.com/571200 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#489264} [modify] https://crrev.com/9bd6882a7344b149f5fa8f9c4a4b0d80dadc64e0/ui/message_center/views/bounded_label.cc [modify] https://crrev.com/9bd6882a7344b149f5fa8f9c4a4b0d80dadc64e0/ui/message_center/views/bounded_label.h [modify] https://crrev.com/9bd6882a7344b149f5fa8f9c4a4b0d80dadc64e0/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/9bd6882a7344b149f5fa8f9c4a4b0d80dadc64e0/ui/message_center/views/notification_view_md.h [modify] https://crrev.com/9bd6882a7344b149f5fa8f9c4a4b0d80dadc64e0/ui/message_center/views/notification_view_md_unittest.cc
,
Jul 26 2017
,
Aug 4 2017
,
Aug 4 2017
Approving merge to M61 Chrome OS.
,
Aug 8 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3a0fd9249d2d0ab7f667dc0c96c514e0d58d1ed commit e3a0fd9249d2d0ab7f667dc0c96c514e0d58d1ed Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Aug 09 05:34:24 2017 Fix message expansion bug in MD notification. In MD notification, simple notification was not properly expanded when expand button was clicked. This was caused by a bug BoxLayout does not properly handle a view that use its width to calculate the height such as BoundedLabel (https://crbug.com/682266). We workaround this instead because there's no obvious solution, and the number of affected classes by BoxLayout change is large. The detail is written in the comment. BUG= 736998 TEST=out/Debug/message_center_unittests TBR=tetsui@chromium.org (cherry picked from commit 9bd6882a7344b149f5fa8f9c4a4b0d80dadc64e0) Change-Id: I2cb5d1e20376e259f1090cbfd03eb55ef55c275b Reviewed-on: https://chromium-review.googlesource.com/571200 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489264} Reviewed-on: https://chromium-review.googlesource.com/602102 Cr-Commit-Position: refs/branch-heads/3163@{#401} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/e3a0fd9249d2d0ab7f667dc0c96c514e0d58d1ed/ui/message_center/views/bounded_label.cc [modify] https://crrev.com/e3a0fd9249d2d0ab7f667dc0c96c514e0d58d1ed/ui/message_center/views/bounded_label.h [modify] https://crrev.com/e3a0fd9249d2d0ab7f667dc0c96c514e0d58d1ed/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/e3a0fd9249d2d0ab7f667dc0c96c514e0d58d1ed/ui/message_center/views/notification_view_md.h [modify] https://crrev.com/e3a0fd9249d2d0ab7f667dc0c96c514e0d58d1ed/ui/message_center/views/notification_view_md_unittest.cc
,
Jan 22 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tetsui@chromium.org
, Jun 27 2017Labels: md-notification