Add ripple effect to new-style notification header |
||||
Issue descriptionAccording to the notification mock, notification header will have ripple effect when tapped / clicked. https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZYhMpwexg3v6/files/MCEscR8UkuHOdZhuFTerqv77wMSJbxAVNpw
,
Jun 27 2017
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07abab334b42055ce5a277f78c78d39f584e5296 commit 07abab334b42055ce5a277f78c78d39f584e5296 Author: tetsui <tetsui@chromium.org> Date: Thu Jun 29 16:22:53 2017 Add ripple effect to new-style notification header. BUG= 736996 TEST=manual Review-Url: https://codereview.chromium.org/2959363002 Cr-Commit-Position: refs/heads/master@{#483381} [modify] https://crrev.com/07abab334b42055ce5a277f78c78d39f584e5296/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/07abab334b42055ce5a277f78c78d39f584e5296/ui/message_center/views/notification_header_view.h
,
Jul 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/984a15c405577aff40ac40636b010231c1009f33 commit 984a15c405577aff40ac40636b010231c1009f33 Author: tetsui <tetsui@chromium.org> Date: Tue Jul 04 03:11:13 2017 Add ripple effect to action in expand button. In new-style notification, click inside the expand button in the header could not trigger ripple effect animation. This CL forwards mouse and key events to NotificationHeaderView. The CL also disables ripple effect when the expand button is disabled. BUG= 736996 TEST=manual Review-Url: https://codereview.chromium.org/2966673002 Cr-Commit-Position: refs/heads/master@{#484045} [modify] https://crrev.com/984a15c405577aff40ac40636b010231c1009f33/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/984a15c405577aff40ac40636b010231c1009f33/ui/message_center/views/notification_header_view.h [modify] https://crrev.com/984a15c405577aff40ac40636b010231c1009f33/ui/message_center/views/notification_view_md.cc
,
Jul 4 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tetsui@chromium.org
, Jun 27 2017