target=_blank pages don't open from PWAs |
||||
Issue descriptionChrome Version: Tested on Dev and Canary. Works fine on stable. OS: Android What steps will reproduce the problem? (1) Add a PWA to your homescreen e.g. https://g-ortuno.github.io/pwa-sandbox/ (2) Open PWA (3) Click a link that has target="_blank" What is the expected result? Link should load in a CCT. What happens instead? CCT opens but it just hangs and still hangs after reloading. Attached video.
,
Jun 28 2017
,
Jun 29 2017
,
Jul 5 2017
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bf1a0ba5782af6e950604667ecf1882b189c858 commit 7bf1a0ba5782af6e950604667ecf1882b189c858 Author: piotrs <piotrs@chromium.org> Date: Thu Jul 06 00:22:10 2017 Fixes stuck navigation when opening PWA in-scope page in CCT. The issues was happening because CustomTabActivity was requesting to load the URL on the WebContents it received. URL loading was already happening at this point, as navigation was initiated in the renderer earlier. It worked for URLs with different origin, as re-requesting the URL load was causing creating new RenderFrame in a new Renderer process. For the URL with the same origin however the new request somehow clashed with the previous request in a way I cannot fully explain and navigation never finished. The fix is to ask the WebContents to resume loading instead of re-requesting it. This is also what happens in a ChromeTabbedActivity on clicking _blank links and is much faster than what I did in previous patch. BUG= 736995 Review-Url: https://codereview.chromium.org/2964183002 Cr-Commit-Position: refs/heads/master@{#484407} [modify] https://crrev.com/7bf1a0ba5782af6e950604667ecf1882b189c858/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java [modify] https://crrev.com/7bf1a0ba5782af6e950604667ecf1882b189c858/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java
,
Jul 6 2017
This should be fixed now! |
||||
►
Sign in to add a comment |
||||
Comment 1 by piotrs@chromium.org
, Jun 27 2017