New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 736963 link

Starred by 1 user
Status: Assigned
Owner:
steve...@chromium.org
Cc:
aee@chromium.org
█ scottchen@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Settings: Network: Correctly focus network in list after returning from details page

Project Member Reported by steve...@chromium.org, Jun 27 2017 
Extracted from  issue 714350 

The following code in SettingsInternetPage.currentRouteChanged() fails to correctly select the last visited network:

      selector = '* /deep/ #networkList';
      if (this.detailGUID_) {
        selector += ' /deep/ cr-network-list-item[guid="' + this.detailGUID_ +
            '"] /deep/ .subpage-arrow';
      }

I confirmed that the element is getting focused in settings_animated_pages.js correctly, but I suspect there is a conflict with iron-list selection.

This will require some additional / extra effort to solve.

Comment 1 by dpa...@chromium.org, Jun 27 2017 

Are you sure that the elements is not being focused correctly? Note that dbeam@ landed code to intentionally hide the ripple while still focusing the correct element. In other words, can you verify that the focus is incorrectly restored by hitting tab a couple of times?

Comment 2 by steve...@chromium.org, Jun 27 2017 

I'm not sure I understand what you mean.

The iron-list itself ends up being focused instead of the individual element.

Comment 3 by dpa...@chromium.org, Jul 12

Cc: aee@chromium.org
FYI, we are removing /deep/ usage per issue 860069.

@aee: This might be one more case where deep is used but the code is not fully working.
►

Sign in to add a comment