[Media Router] Paper-sliders in the WebUI route controller are reversed when using a RTL language |
||
Issue descriptionWhen the user language is RTL, the Polymer sliders in the new WebUI route controller go RTL as well. Given Chrome's HTML video and YouTube volume/seek sliders go LTR even if the rest of the page is RTL, we should force our sliders to go LTR as well. However, due to a bug in <paper-slider> [1], we can't force the direction of the <paper-slider> to be LTR by adding a dir="ltr" attribute to it. [1] https://github.com/PolymerElements/paper-slider/issues/190
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09ac01b33652a775acb4f1368028c7c825d8f423 commit 09ac01b33652a775acb4f1368028c7c825d8f423 Author: Takumi Fujimoto <takumif@chromium.org> Date: Mon Jul 10 22:41:21 2017 Update Polymer paper-slider to v2.0.2 Update from v1.0.15 by running third_party/polymer/v1_0/reproduce.sh. This includes the fix for a bug in which the slider cannot be LTR on a RTL page. Bug: 736954 Change-Id: I73f77fb0a053ec7f00b996a125f853848fbc56b6 Reviewed-on: https://chromium-review.googlesource.com/565067 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#485429} [modify] https://crrev.com/09ac01b33652a775acb4f1368028c7c825d8f423/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/09ac01b33652a775acb4f1368028c7c825d8f423/third_party/polymer/v1_0/components-chromium/paper-slider/bower.json [modify] https://crrev.com/09ac01b33652a775acb4f1368028c7c825d8f423/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js [modify] https://crrev.com/09ac01b33652a775acb4f1368028c7c825d8f423/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html [modify] https://crrev.com/09ac01b33652a775acb4f1368028c7c825d8f423/third_party/polymer/v1_0/components_summary.txt
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/586fd7fff297ff450c32c3d677286da68bfed26f commit 586fd7fff297ff450c32c3d677286da68bfed26f Author: Takumi Fujimoto <takumif@chromium.org> Date: Tue Jul 11 16:58:07 2017 [Media Router] Force seek and volume sliders to be LTR for RTL languages By setting dir="ltr" attribute on the paper-sliders, we force them to go LTR regardless of language settings, to be consistent with other media players. Bug: 736954 Change-Id: I2079561225c00925671ac06878f525ca85a160d7 Reviewed-on: https://chromium-review.googlesource.com/565219 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#485656} [modify] https://crrev.com/586fd7fff297ff450c32c3d677286da68bfed26f/chrome/browser/resources/media_router/elements/route_controls/route_controls.html
,
Jul 11 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by taku...@chromium.org
, Jun 27 2017