Issue metadata
Sign in to add a comment
|
Gerrit Sends E-mails Prematurely |
||||||||||||||||||||||||
Issue descriptionI just sent https://chromium-review.googlesource.com/c/549223/ for a CQ Dry Run just to see how it performed without intending it to send it to review yet. I also abandoned a change (https://chromium-review.googlesource.com/c/549222/) without sending it for review. In both cases, Gerrit spammed everyone on the Cc list, making it look like one changelist was ready for review (when it wasn't) and unnecessarily notifying everyone of a throwaway changelist. Gerrit should not be sending e-mails if the author did not take action to publish the review (e.g. by adding reviewers).
,
Jun 27 2017
,
Jun 27 2017
Although the summary of the bug I'm duping this one into makes it sound like the opposite problem, they're rooted in the same cause and have the same fix. In the very near future (like, maybe today) I'll be landing a change which makes "git cl upload" upload changes in Work-In-Progress mode. This suppresses the kinds of emails that you're referencing in this bug, and should resolve this issue.
,
Jun 29 2017
Even when not WIP: shouldn't reviewers not get CQ dry-run emails? I find I get way too many emails as a reviewer from Gerrit (compared to Reitveld). Le mar. 27 juin 2017 11:59, agable via monorail < monorail+v2.4092810879@chromium.org> a écrit : |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by robliao@chromium.org
, Jun 27 2017