New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736944 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Update Chrome Upstream to reflect new UX mocks

Project Member Reported by jsaul@google.com, Jun 27 2017

Issue description

Tracking bug for the eng work to Chrome Upstream to reflect the new UX mocks, including the CVC fix flow.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 12 2017

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19ef81cf629066734a0fd1d1699d43ee307af659

commit 19ef81cf629066734a0fd1d1699d43ee307af659
Author: jsaul <jsaul@google.com>
Date: Wed Aug 09 18:54:49 2017

Update Chrome Upstream flow (Chrome -> Payments upload credit card save for Autofill) to reflect new UI mocks

Mocks: https://docs.google.com/presentation/d/135dRphfYbqnbdWqsHf2Kjth1HzMjidKwLq94i-0RCOQ/edit#slide=id.g1e6c4c1b7a_2_49

BUG= 736944 

Review-Url: https://codereview.chromium.org/2955963002
Cr-Commit-Position: refs/heads/master@{#493080}

[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/about_flags.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/components/autofill/core/browser/ui/mock_save_card_bubble_controller.h
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/components/autofill_strings.grdp
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/19ef81cf629066734a0fd1d1699d43ee307af659/ui/views/bubble/bubble_frame_view_unittest.cc

Comment 3 by zkoch@chromium.org, Aug 9 2017

I don't think these changes have been approved by UX. Jared, could you take some screenshots of your implementation so I can reach out?

Comment 4 by jsaul@google.com, Aug 9 2017

Cc: mikeying@google.com
You're correct, Zach, and we won't turn the flag on without that approval.  This is the base redesign that accompanies the CVC fix flow.  Mike's meeting with UX right now to solidify the branding changes mocks, which we'll run by Ainslie.  I'm also updating the design doc to send out.

I'll send you screenshots by the end of the day; Mike requested the same thing.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec793912557009d0dd0bdb3a5fe71fed084c2cf3

commit ec793912557009d0dd0bdb3a5fe71fed084c2cf3
Author: Jared Saul <jsaul@google.com>
Date: Sat Aug 12 00:15:04 2017

Additional CVC fix flow UI changes
- Adding expiration back for updated UI
- CVC fix flow without updated UI should say Next->Confirm, not Save->Save

Bug:  736944 
Change-Id: I7defdd2e95d9bf9741bb587982f65e9414d0fe7b
Reviewed-on: https://chromium-review.googlesource.com/611383
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#493892}
[modify] https://crrev.com/ec793912557009d0dd0bdb3a5fe71fed084c2cf3/chrome/browser/ui/views/autofill/save_card_bubble_views.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4446d1bba7fa41781d5455895bae2643d4a8158

commit e4446d1bba7fa41781d5455895bae2643d4a8158
Author: Jared Saul <jsaul@google.com>
Date: Tue Aug 15 20:01:13 2017

Update Google branding for updated card upload UI experiment (behind a flag)

Bug:  736944 
Change-Id: Id5a51adf2b34713220c1b043b5f04cdd4a228726
Reviewed-on: https://chromium-review.googlesource.com/611727
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#494511}
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/chrome/app/vector_icons/google_g_logo.icon
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/chrome/browser/about_flags.cc
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/components/autofill_strings.grdp
[modify] https://crrev.com/e4446d1bba7fa41781d5455895bae2643d4a8158/tools/metrics/histograms/enums.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320ac7b5fea2ece2889cb4c4082032e77e555c15

commit 320ac7b5fea2ece2889cb4c4082032e77e555c15
Author: Jared Saul <jsaul@google.com>
Date: Thu Aug 24 18:34:32 2017

Change Google branding logo from 20px to 16px
This is a request from bettes@ due to the G logo not having built-in 2px padding.

Bug:  736944 
Change-Id: Iec4f6cbc20dd0dcfdb5ae0da4def608cd7913760
Reviewed-on: https://chromium-review.googlesource.com/631037
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#497134}
[modify] https://crrev.com/320ac7b5fea2ece2889cb4c4082032e77e555c15/chrome/browser/ui/views/autofill/save_card_bubble_views.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48ba9c40ee72f1cbb33d675e248dd918da483ed

commit c48ba9c40ee72f1cbb33d675e248dd918da483ed
Author: Jared Saul <jsaul@google.com>
Date: Fri Aug 25 18:28:58 2017

Fix strings for ChromeOS

Bug:  736944 
Change-Id: I3d566a4c37244b2248f0fe0bdae36c91409c08de
Reviewed-on: https://chromium-review.googlesource.com/636026
Commit-Queue: Jared Saul <jsaul@google.com>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497472}
[modify] https://crrev.com/c48ba9c40ee72f1cbb33d675e248dd918da483ed/components/autofill_strings.grdp

Comment 10 by ma...@chromium.org, Sep 26 2017

Issue 654112 has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d632f9cca131c286682e70b544319b52318479c

commit 5d632f9cca131c286682e70b544319b52318479c
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu Sep 28 00:37:09 2017

[Autofill] Credit card local save dialog shouldn't have window icon

Previously, all card save dialogs under the new UI would have the logo.
The logo should only apply to server card uploads, not local saves.

Bug:  736944 ,  768951 
Change-Id: I7b5a8845f66e808cba13e2822c6dd8ed50995056
Reviewed-on: https://chromium-review.googlesource.com/685503
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504817}
[modify] https://crrev.com/5d632f9cca131c286682e70b544319b52318479c/chrome/browser/ui/views/autofill/save_card_bubble_views.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 29 2017

Labels: merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43a90c557dda01865ef1108fe3d836d8f2fc0929

commit 43a90c557dda01865ef1108fe3d836d8f2fc0929
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Sep 29 20:37:01 2017

[Autofill] Credit card local save dialog shouldn't have window icon

Previously, all card save dialogs under the new UI would have the logo.
The logo should only apply to server card uploads, not local saves.

TBR=mathp@chromium.org

(cherry picked from commit 5d632f9cca131c286682e70b544319b52318479c)

Bug:  736944 ,  768951 
Change-Id: I7b5a8845f66e808cba13e2822c6dd8ed50995056
Reviewed-on: https://chromium-review.googlesource.com/685503
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504817}
Reviewed-on: https://chromium-review.googlesource.com/692700
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#520}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/43a90c557dda01865ef1108fe3d836d8f2fc0929/chrome/browser/ui/views/autofill/save_card_bubble_views.cc

Comment 13 by jsaul@google.com, Dec 6 2017

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5e394bccb9c2a268e4c6844861dabc720ca6490

commit c5e394bccb9c2a268e4c6844861dabc720ca6490
Author: Jared Saul <jsaul@google.com>
Date: Tue Dec 12 17:49:11 2017

Make AutofillUpstreamShowNewUi and AutofillUpstreamShowGoogleLogo behavior default

Bug:  736944 
Change-Id: I718a06fd59eb773512545054aaecd89ff9fbe0cd
Reviewed-on: https://chromium-review.googlesource.com/820619
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#523469}
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/chrome/browser/about_flags.cc
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/c5e394bccb9c2a268e4c6844861dabc720ca6490/tools/metrics/histograms/enums.xml

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db75f306dd6169bcc32227373ba8b4c14ee5b64e

commit db75f306dd6169bcc32227373ba8b4c14ee5b64e
Author: Jared Saul <jsaul@google.com>
Date: Thu Dec 14 23:54:01 2017

Update waterfall testing config for new Chrome Upstream launches

Make the following changes:

* Remove AutofillUpstreamShowGoogleLogo and AutofillUpstreamShowNewUi.  The code has been updated to make those default.
* Add Mac to AutofillUpstreamRequestCvcIfMissing in preparation of the M64 launch.
* Add config for AutofillUpstreamSendDetectedValues and AutofillUpstreamSendPanFirstSix, part of the Upstream Partial Data Project targeting M65.

Bug:  736944 ,  789645 ,  793490 
Change-Id: If6888d203dbceb3dcba8d38184244375c9cb110a
Reviewed-on: https://chromium-review.googlesource.com/827631
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#524234}
[modify] https://crrev.com/db75f306dd6169bcc32227373ba8b4c14ee5b64e/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment