New issue
Advanced search Search tips

Issue 736943 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security

Blocked on:
issue 736986

Blocking:
issue 594639



Sign in to add a comment

Bad-cast to blink::TraceWrapperBase from invalid vptr;blink::ScriptWrappableVisitor::DispatchTraceWrappers;blink::TraceTrait<blink::Modulator>::TraceMarkedWrapper

Project Member Reported by ClusterFuzz, Jun 26 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5223648893075456

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x1257d4825010
Crash State:
  Bad-cast to blink::TraceWrapperBase from invalid vptr
  blink::ScriptWrappableVisitor::DispatchTraceWrappers
  blink::TraceTrait<blink::Modulator>::TraceMarkedWrapper
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=482161:482274

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5223648893075456


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 27 2017

Labels: M-61
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 27 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 27 2017

Labels: Pri-1

Comment 4 by mmoroz@chromium.org, Jun 27 2017

Blockedon: 736986
Components: Blink>Bindings
Owner: mlippautz@chromium.org
Looks very similar to  issue 736986 .

Assigning this to mlippautz@ for now. Michael, please feel free to un-assign if this is not related to your changes.
Cc: keishi@chromium.org
Similar, Keishi, does this by chance ring a bell? We haven't changed the base infra for some time now, so this is a bit of a surprise.
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 28 2017

Status: Assigned (was: Untriaged)
Cc: hirosh...@chromium.org mlippautz@chromium.org haraken@chromium.org
Owner: kouhei@chromium.org
Same here. Module loading related.
I might have some time on the train where I can try to spot the issue. Wanted to assign the proper bug owner though.
Blocking: 594639
Components: Blink>HTML>Script
Status: Started (was: Assigned)
Project Member

Comment 12 by ClusterFuzz, Jun 29 2017

Labels: OS-Mac
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/754391155e5467e1bbe6679c32745bc2d1a8797b

commit 754391155e5467e1bbe6679c32745bc2d1a8797b
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Jun 29 12:03:50 2017

[ES6 modules] Add missing Trace(LocalDOMWindow -> modulator_)

Bug:  736943 
Change-Id: I13932a19dc22ba1431ca47bbfb7038f79e6e9928
Reviewed-on: https://chromium-review.googlesource.com/554438
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483330}
[modify] https://crrev.com/754391155e5467e1bbe6679c32745bc2d1a8797b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Status: Fixed (was: Started)
Project Member

Comment 15 by sheriffbot@chromium.org, Jun 29 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 16 by ClusterFuzz, Jun 30 2017

ClusterFuzz has detected this issue as fixed in range 483281:483374.

Detailed report: https://clusterfuzz.com/testcase?key=5223648893075456

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x1257d4825010
Crash State:
  Bad-cast to blink::TraceWrapperBase from invalid vptr
  blink::ScriptWrappableVisitor::DispatchTraceWrappers
  blink::TraceTrait<blink::Modulator>::TraceMarkedWrapper
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=482161:482274
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=483281:483374

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5223648893075456


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -ReleaseBlock-Stable
Project Member

Comment 18 by sheriffbot@chromium.org, Oct 5 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment