New issue
Advanced search Search tips

Issue 736932 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Implement the host instruction page

Project Member Reported by yuweih@chromium.org, Jun 26 2017

Issue description

Need to implement the host instruction page to be shown when the user has no host set up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3872416cbc8896a54bb571539202bf0e24fcac2

commit e3872416cbc8896a54bb571539202bf0e24fcac2
Author: yuweih <yuweih@chromium.org>
Date: Wed Jun 28 01:03:37 2017

[CRD iOS] Add the host setup instruction page

This CL adds the host setup view to inform the user to setup the host when
there is no host in the list. Please see this screenshot:
https://drive.google.com/file/d/0BytzIZKeM8nBdzBoWlN3R3hGSWM/view?usp=sharing

This CL also fixes some color scheme issue. Previously the host collection list
is using opacity to lighten the color.

BUG= 736932 

Review-Url: https://codereview.chromium.org/2957943002
Cr-Commit-Position: refs/heads/master@{#482832}

[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/BUILD.gn
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/app_delegate.h
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/app_delegate.mm
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_collection_view_cell.mm
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_collection_view_controller.h
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_collection_view_controller.mm
[add] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_setup_footer_view.h
[add] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_setup_footer_view.mm
[add] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_setup_header_view.h
[add] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_setup_header_view.mm
[add] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_setup_view_cell.h
[add] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_setup_view_cell.mm
[add] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_setup_view_controller.h
[add] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/host_setup_view_controller.mm
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/remoting_theme.h
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/remoting_theme.mm
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/app/remoting_view_controller.mm
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/facade/host_list_fetcher.cc
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/facade/remoting_service.h
[modify] https://crrev.com/e3872416cbc8896a54bb571539202bf0e24fcac2/remoting/ios/facade/remoting_service.mm

Comment 2 by yuweih@chromium.org, Jun 28 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e56f943673a2b277544e7b07f037121bfdc561

commit c6e56f943673a2b277544e7b07f037121bfdc561
Author: Yuwei Huang <yuweih@chromium.org>
Date: Wed Jul 19 18:05:48 2017

[CRD iOS] Hide the send email button

Since we are not going to implement the send email feature soon, this CL
hides the send email button in the host instruction page.

This CL replaces the HostSetupFooterView with an empty view.

Bug:  736932 
Change-Id: Id3ce3faea6f2352667904eb48d4e811587254d82
Reviewed-on: https://chromium-review.googlesource.com/575302
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487913}
[modify] https://crrev.com/c6e56f943673a2b277544e7b07f037121bfdc561/remoting/ios/app/host_setup_view_controller.mm

Status: Verified (was: Fixed)
Verified in 63.0.3220.0

Sign in to add a comment