New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736931 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

<esc> with multiple tab-to-search entries corrupts omnibox

Project Member Reported by mpear...@chromium.org, Jun 26 2017

Issue description


For my history and search settings,  (hostnames somewhat revised to prevent leaking information)
1. Type "mo" and see a list of suggestions including
  1. mo|ab.park.example.com as an inline autocomplete suggestion with a tab-to-search icon showing
  2. moab as a second suggestion, also with a tab-to-search icon showing
  3. maybe more suggestions
2. Press tab twice, the first time switches into keyword search mode for the first suggestion, the second time switch to the second suggestions but doesn't enter keyword search mode.
4. Press escape.

Expected result:
* Either the omnibox becomes blank (clears all edits)
or
* The omnibox reverts to what it was before I started pressing tab, i.e., the text "mo" in the omnibox, possibly with the inline autocompletion "ab.park.example.com"

Actual result:
* The omnibox reverts to the text "ab", with an inline autocompletion of ".park.example.com".

It seems like we're forgetting the original text, only remembering the inline autocompletion, yet trying to apply the cursor position from the original text.

By the way, pressing enter goes to the right place.
 
Also see bug 705262, which is the same situation without an inline autocompletion.  (The typed text disappears.)

Cc: timbrown@chromium.org
Labels: Hotlist-Polish
Reduced description:

If you tab across an entry with an associated keyword (thus traversing through keyword mode briefly), then hit esc, then we try to restore the user text + inline autocomplete text; but the user text is empty due to going into keyword mode.

Basically, when tabbing away from keyword mode, we need to restore the user's original text in the internal fields, so that esc can revert things correctly.
Labels: OS-Windows
Reproduced on Windows by pkasting@. I suspect this affects Mac (and maybe Chrome) too, but don't have the devices to confirm.
Labels: OS-Chrome OS-Mac
Broken on Mac too.

Sign in to add a comment