New issue
Advanced search Search tips

Issue 736928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 662995



Sign in to add a comment

Don't let AndroidVideoSurfaceChooser retry for an overlay too often

Project Member Reported by liber...@chromium.org, Jun 26 2017

Issue description

if we fail an overlay request, don't keep requesting one.  for example, even if we're really sure that an overlay is a good idea, if we're at the MAX_OVERLAYS limit in AndroidOverlayProviderImpl, then requesting one every frame won't help.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc568e22f5b341c28a6671083bc56b30433985e6

commit fc568e22f5b341c28a6671083bc56b30433985e6
Author: liberato@chromium.org <liberato@chromium.org>
Date: Tue Jun 27 01:31:32 2017

Add minimum retry time for AndroidVideoSurfaceChooserImpl.

To prevent repeated requests for an overlay, this CL requires a
ten second delay between one failed overlay request and the next.

Bug:  736928 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I30df6fa776106e9db641c2c9455337dd71d37669
Reviewed-on: https://chromium-review.googlesource.com/549034
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482500}
[modify] https://crrev.com/fc568e22f5b341c28a6671083bc56b30433985e6/media/gpu/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/fc568e22f5b341c28a6671083bc56b30433985e6/media/gpu/android_video_surface_chooser_impl.h
[modify] https://crrev.com/fc568e22f5b341c28a6671083bc56b30433985e6/media/gpu/android_video_surface_chooser_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment