New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736925 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Rename IsSmartVirtualKeyboardEnabled to IsVirtualKeyboardEnabled

Project Member Reported by oka@chromium.org, Jun 26 2017

Issue description

"Smart" is confusing because now it's the default.
 

Comment 1 by oka@chromium.org, Jun 26 2017

Maybe "ForceEnabled" is better, because IIUC the enable-virtual-keyboard flag is just for debugging to force-enable the virtual keyboard on laptop mode.

Comment 2 by oka@chromium.org, Jun 26 2017

Also remove kSmartVirtualKeyboardName.

Comment 3 by oka@chromium.org, Jun 26 2017

Labels: Hotlist-GoodFirstBug

Comment 4 by oka@chromium.org, Jun 26 2017

Labels: OS-Chrome

Comment 5 by blakeo@chromium.org, Jun 27 2017

Owner: blakeo@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e93ae7a4257b71f5adb68295cfbafdd898edfcca

commit e93ae7a4257b71f5adb68295cfbafdd898edfcca
Author: Blake O'Hare <blakeo@chromium.org>
Date: Tue Jul 18 02:48:04 2017

Rename IsSmartVirtualKeyboardEnabled to IsVirtualKeyboardEnabled

Bug:  736925 
Change-Id: Ib50980632c779f3ba9ffc01474f8a0009cc06763
Reviewed-on: https://chromium-review.googlesource.com/566159
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487354}
[modify] https://crrev.com/e93ae7a4257b71f5adb68295cfbafdd898edfcca/ash/virtual_keyboard_controller.cc

Comment 8 by blakeo@chromium.org, Jul 27 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment