Visit is only recorded if it is the main frame. We should handle playbacks attribution correctly here.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe commit 4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Jul 24 13:12:35 2017 Media Engagement: Add browser tests Add browser tests to test each significance factor is correctly measured by MediaEngagementContentsObserver. Also tests that cross origin iFrames are correctly recorded. BUG= 736914 Change-Id: Iefbe5d627697e7e0dcf23e0f2db60ae286c6b10c Reviewed-on: https://chromium-review.googlesource.com/570163 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#488958} [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/browser/media/media_engagement_browsertest.cc [modify] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/browser/media/media_engagement_contents_observer.cc [modify] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/browser/media/media_engagement_contents_observer.h [modify] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/browser/media/media_engagement_service.h [modify] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/BUILD.gn [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/OWNERS [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_100px_100px_frame_size.webm [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_no_audio_track.webm [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_silent_audio_track.webm [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_test.html [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_test.js [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_test_iframe.html [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_test_iframe_child.html [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_test_muted.html [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_test_no_audio_track.html [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_test_silent_audio_track.html [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_test_small_frame_size.html [add] https://crrev.com/4b405faf6f091af5518ae4ca3bd7a009d6bd1cbe/chrome/test/data/media/engagement/engagement_valid_video.webm
Comment 1 by beccahughes@chromium.org
, Jul 10 2017