New issue
Advanced search Search tips

Issue 736911 link

Starred by 0 users
Status: Archived
Owner:
ayatane@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Add proper unittests for sysmon

Project Member Reported by ayatane@chromium.org, Jun 26 2017 
I keep breaking sysmon with silly typos because I punted writing good unittests due to the difficulty in mocking out ts_mon, and since sysmon is hard to test manually and manual tests suck

Pretty much every change I've made has had a silly typo.  This is exacerbated by the copy-paste nature of sysmon code.

Add proper unittests for sysmon.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c8acdec7f6fe15cc6bb8bfa73844aaee63c4a688

commit c8acdec7f6fe15cc6bb8bfa73844aaee63c4a688
Author: Allen Li <ayatane@chromium.org>
Date: Tue Jun 27 00:51:19 2017

sysmon: Fix typo

BUG=chromium:724580
BUG= chromium:736911 
TEST=None

Change-Id: I6ce8383fa04e7433204d2a1066b8264364a7f139
Reviewed-on: https://chromium-review.googlesource.com/549183
Reviewed-by: Paul Hobbs <phobbs@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Trybot-Ready: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/c8acdec7f6fe15cc6bb8bfa73844aaee63c4a688/scripts/sysmon/git_metrics.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5956da64d5125556e36a0deda714a779dbf3da4e

commit 5956da64d5125556e36a0deda714a779dbf3da4e
Author: Allen Li <ayatane@chromium.org>
Date: Tue Jun 27 20:31:46 2017

sysmon: Fix handling git diff-index outputting dashes

BUG= chromium:736911 
BUG=chromium:737146
BUG=chromium:737217
TEST=Run on backup cautotest

Change-Id: Icd566e5ef49e43233b0415508b7542b0b4464e10
Reviewed-on: https://chromium-review.googlesource.com/550560
Commit-Queue: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Trybot-Ready: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/5956da64d5125556e36a0deda714a779dbf3da4e/scripts/sysmon/git_metrics.py
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/36b8a8bf19abfd11443ac81e530079a5f27d4c57

commit 36b8a8bf19abfd11443ac81e530079a5f27d4c57
Author: Allen Li <ayatane@chromium.org>
Date: Wed Jun 28 23:25:03 2017

sysmon: Fix yet another typo

This is the third typo I have had to fix in this bit of copy-pasted
code.

BUG= chromium:736911 
BUG=chromium:737146
BUG=chromium:737217
TEST=None

Change-Id: I14ed0337c64c58bc4868aff2a338eddc9a51eb3d
Reviewed-on: https://chromium-review.googlesource.com/553458
Reviewed-by: Paul Hobbs <phobbs@google.com>
Tested-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/36b8a8bf19abfd11443ac81e530079a5f27d4c57/scripts/sysmon/git_metrics.py
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a9c52e3cced5b8ddd780783f0939f0558b39fafe

commit a9c52e3cced5b8ddd780783f0939f0558b39fafe
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jul 15 04:40:46 2017

sysmon: Add sysmon.net_metrics tests

BUG= chromium:736911 
TEST=None

Change-Id: I57aaf1fd6e22bcd86c91c0bd6045d9b8ff864a95
Reviewed-on: https://chromium-review.googlesource.com/570506
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/a9c52e3cced5b8ddd780783f0939f0558b39fafe/scripts/sysmon/net_metrics_unittest.py
[add] https://crrev.com/a9c52e3cced5b8ddd780783f0939f0558b39fafe/scripts/sysmon/net_metrics_unittest
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c54362dbf380468fceb5c5488a470d734aaea7b8

commit c54362dbf380468fceb5c5488a470d734aaea7b8
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jul 15 04:40:45 2017

sysmon: Add sysmon.loop tests

BUG= chromium:736911 
TEST=None

Change-Id: Ifbdabbe974d4044a64a060831697f4449a23714f
Reviewed-on: https://chromium-review.googlesource.com/570634
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[add] https://crrev.com/c54362dbf380468fceb5c5488a470d734aaea7b8/scripts/sysmon/loop_unittest.py
[add] https://crrev.com/c54362dbf380468fceb5c5488a470d734aaea7b8/scripts/sysmon/loop_unittest
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/060e84c9a949f6a861a47cc0916170892c94bb16

commit 060e84c9a949f6a861a47cc0916170892c94bb16
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jul 15 04:40:46 2017

sysmon: Add sysmon.git_metrics tests

BUG= chromium:736911 
TEST=None

Change-Id: I846b74e6f7707709b92c96fc32b130dca5497350
Reviewed-on: https://chromium-review.googlesource.com/570635
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/060e84c9a949f6a861a47cc0916170892c94bb16/scripts/sysmon/git_metrics_unittest.py
[add] https://crrev.com/060e84c9a949f6a861a47cc0916170892c94bb16/scripts/sysmon/git_metrics_unittest
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7ceee3674ff7353501dc28d9d2bb5aa6e655f10c

commit 7ceee3674ff7353501dc28d9d2bb5aa6e655f10c
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jul 15 04:40:46 2017

sysmon: Remove duplicate net metrics

BUG= chromium:736911 
TEST=None

Change-Id: I861d11ab1fab9ae0538a75c66903c0063f59bb21
Reviewed-on: https://chromium-review.googlesource.com/570764
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/7ceee3674ff7353501dc28d9d2bb5aa6e655f10c/scripts/sysmon/net_metrics.py
[modify] https://crrev.com/7ceee3674ff7353501dc28d9d2bb5aa6e655f10c/scripts/sysmon/net_metrics_unittest.py
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0186c4a452f4dc77afd147a2ce3efa1579743e9d

commit 0186c4a452f4dc77afd147a2ce3efa1579743e9d
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jul 15 04:40:47 2017

sysmon: Add prod metrics tests

BUG= chromium:736911 
TEST=None

Change-Id: I3023785938cb19f7696ce89ada1cb08632850077
Reviewed-on: https://chromium-review.googlesource.com/570934
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/0186c4a452f4dc77afd147a2ce3efa1579743e9d/scripts/sysmon/prod_metrics_unittest.py
[add] https://crrev.com/0186c4a452f4dc77afd147a2ce3efa1579743e9d/scripts/sysmon/prod_metrics_unittest
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f8397a80113a421e8c78f13ed572ef0a4347ed80

commit f8397a80113a421e8c78f13ed572ef0a4347ed80
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jul 15 04:40:47 2017

sysmon: Improve how other metric is calculated

BUG= chromium:736911 
TEST=None

Change-Id: I34713b97604b4078d49aef6404656875df5ced3b
Reviewed-on: https://chromium-review.googlesource.com/570944
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/f8397a80113a421e8c78f13ed572ef0a4347ed80/scripts/sysmon/proc_metrics.py

Comment 14 by ayatane@chromium.org, Mar 10 2018

Status: Archived (was: Assigned)
►

Sign in to add a comment