New issue
Advanced search Search tips

Issue 736906 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocked on:
issue 737191



Sign in to add a comment

NetworkService can't be used in Chrome

Project Member Reported by mmenke@chromium.org, Jun 26 2017

Issue description

All the of NetworkService's objects are in content/common, so they can't be used in Chrome.  They're in that directory largely because ResourceRequest depends on a number of private content/ enums classes.  Also, the network service just ignores all these enums, since they're currently instructions to AppCache and ServiceWorker, which the NEtworkService doesn't care about.

So we're left with a couple options:

* Make the enum classes public, just for this use.
* Depend on file in content/common directly.  Since they're headers, and the only classes of concern are enum classes, this should just work, but seems ugly. We could also just move the mojo files to content/public/common, and leave the enums where they are, using the same reasoning.
* Make a new way of creating URLLoaders that doesn't depend on these APIs.  This seems too icky, since we'd have to have content-specific mojo subclasses that implement the new APIs and the old ones, basically doubling up interfaces at every layer.

This has to be resolved before we can start migrating service configuration, since Chrome can't configure a service if it can't even depend on the service's interface.
 

Comment 1 by mmenke@chromium.org, Jun 26 2017

My inclination is to make all the enum classes public, along with content::ResourceRequest.

Comment 2 by mmenke@chromium.org, Jun 27 2017

Blockedon: 737191
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947258b6d1913b7f57118386310383c896b90163

commit 947258b6d1913b7f57118386310383c896b90163
Author: mmenke <mmenke@chromium.org>
Date: Thu Jun 29 22:52:14 2017

Merge ResourceRequestBodyImpl and ResourceRequestBody.

The NetworkService's API is currently in content/common, but it needs
to be moved to content/public/common for chrome to use it.  This CL
merges ResourceRequestBodyImpl (in content/common) with
ResourceRequestBody (in content/public/common) as a step towards having
the entire API in content/public/common.

BUG= 736906 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2954343005
Cr-Commit-Position: refs/heads/master@{#483527}

[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/blob_storage/chrome_blob_storage_context.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/child_process_security_policy_impl.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/frame_navigation_entry.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/frame_navigation_entry.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigation_request_info.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigator.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigator.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/loader/DEPS
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/loader/upload_data_stream_builder.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/loader/upload_data_stream_builder.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/loader/upload_data_stream_builder_unittest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/foreign_fetch_request_handler.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/foreign_fetch_request_handler.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/child/resource_dispatcher_unittest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/child/web_url_request_util.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/child/web_url_request_util.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/BUILD.gn
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/android/resource_request_body_android.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/android/resource_request_body_android.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/frame_messages.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/navigation_params.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/navigation_params.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/page_state_serialization.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/page_state_serialization.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/page_state_serialization_unittest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/resource_messages.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/resource_messages.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/common/resource_request.h
[delete] https://crrev.com/00eb7a2dfd3224a58de38a4a202b976e7f0b118f/content/common/resource_request_body_impl.cc
[delete] https://crrev.com/00eb7a2dfd3224a58de38a4a202b976e7f0b118f/content/common/resource_request_body_impl.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/network/url_loader_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/public/common/page_state.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/public/common/resource_request_body.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/public/common/resource_request_body.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/renderer/render_frame_impl.h
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/947258b6d1913b7f57118386310383c896b90163/content/test/test_render_frame.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a4902c07448f1636f48ace6337fcda5891d5d3f

commit 5a4902c07448f1636f48ace6337fcda5891d5d3f
Author: mmenke <mmenke@chromium.org>
Date: Wed Jul 05 18:50:21 2017

Move resource_request.h to content/public/common.

It's used by the network service's API, but was in content/common. For
chrome/ to be able to use the network service directly, the API must
be in content/public/common. Eventually, it will be moved outside of
content.

This also requires splitting service_worker_types.h, so that types
ResourceRequest depends on are also in content/public/common.
Eventually these will need to be removed from the NetworkService's API.

BUG= 736906 

Review-Url: https://codereview.chromium.org/2969463003
Cr-Commit-Position: refs/heads/master@{#484320}

[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/appcache/appcache_url_loader_job.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/appcache/appcache_url_loader_request.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/loader/DEPS
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/loader/async_resource_handler_unittest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/loader/url_loader_factory_impl.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/foreign_fetch_request_handler.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/foreign_fetch_request_handler.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_database.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_handle.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_navigation_handle.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_registration_handle.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/child/request_extra_data.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/child/resource_dispatcher.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/child/resource_dispatcher_unittest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/child/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/child/web_url_request_util.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/common/BUILD.gn
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/common/navigation_params.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/common/resource_messages.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/common/service_worker/service_worker_fetch_request.typemap
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/common/url_request.typemap
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/network/DEPS
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/network/network_service_url_loader_factory_impl.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/public/common/BUILD.gn
[rename] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/public/common/resource_request.cc
[rename] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/public/common/resource_request.h
[add] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/public/common/service_worker_modes.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/renderer/scheduler/resource_dispatch_throttler_unittest.cc
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/5a4902c07448f1636f48ace6337fcda5891d5d3f/content/renderer/service_worker/worker_fetch_context_impl.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/680c214abd32a744f4d929759866a037a6915d2f

commit 680c214abd32a744f4d929759866a037a6915d2f
Author: mmenke <mmenke@chromium.org>
Date: Wed Jul 05 19:08:56 2017

Move NetworkService mojom files to content/public/common.

This will allow chrome/ code to use the NetworkService's API, both to
configure the NetworkService and to issue requests.

Also moves some associated tyemaps and class files over.

BUG= 736906 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2964503003
Cr-Commit-Position: refs/heads/master@{#484325}

[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/appcache/appcache_subresource_url_factory.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/appcache/appcache_url_loader_job.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/blob_storage/blob_internals_url_loader.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/blob_storage/blob_url_loader_factory.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/blob_storage/blob_url_loader_factory.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/histogram_internals_url_loader.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/DEPS
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/downloaded_temp_file_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/mojo_async_resource_handler.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/navigation_url_loader_delegate.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/resource_message_filter.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/test_url_loader_client.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/url_loader_factory_impl.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/url_loader_factory_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/loader/url_loader_request_handler.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/storage_partition_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/url_loader_factory_getter.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/url_loader_factory_getter.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/webui/network_error_url_loader.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/browser/webui/web_ui_url_loader_factory.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/resource_dispatcher.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/resource_dispatcher.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/resource_dispatcher_unittest.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/url_loader_client_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/url_loader_client_impl_unittest.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/url_response_body_consumer.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/url_response_body_consumer.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/child/web_url_loader_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/BUILD.gn
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/renderer_host.mojom
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/resource_messages.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/throttling_url_loader.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/typemaps.gni
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/url_request_struct_traits.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/common/worker_url_loader_factory_provider.mojom
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/network/DEPS
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/network/cache_url_loader.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/network/network_context.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/network/network_service.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/network/network_service_unittest.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/network/network_service_url_loader_factory_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/network/url_loader_impl.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/network/url_loader_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/BUILD.gn
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/mutable_network_traffic_annotation_tag.mojom
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/mutable_network_traffic_annotation_tag.typemap
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/mutable_network_traffic_annotation_tag_struct_traits.h
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/network_service.mojom
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/resource_request_completion_status.cc
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/resource_request_completion_status.h
[add] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/service_worker_modes.typemap
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/ssl_info.typemap
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/typemaps.gni
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/url_loader.mojom
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/url_loader_factory.mojom
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/url_loader_status.typemap
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/url_request.typemap
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/url_request_redirect_info.typemap
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/url_response_head.typemap
[rename] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/public/common/url_sync_load_result.typemap
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/renderer/render_frame_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/renderer/render_thread_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/shell/BUILD.gn
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/test/BUILD.gn
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/680c214abd32a744f4d929759866a037a6915d2f/ipc/README.md

Status: Fixed (was: Assigned)

Comment 7 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment