New issue
Advanced search Search tips

Issue 736875 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
nightlight



Sign in to add a comment

Night Light: On/Off switch in Display settings and status tray to change tint instantaneously

Project Member Reported by ovanieva@chromium.org, Jun 26 2017

Issue description

By design when users set schedule for NL (either sunset/sunrise or custom) the tint is supposed to fade over 20 seconds. On/Off switch behavior should be instantaneous. Currently there is gradual tint change whenever users toggle ON/OFF either from Display settings or from status tray. Let's change that to instantaneous change. The gradual change should apply only to pre-selected schedule.


 
Status: Assigned (was: Untriaged)
We agreed that instantaneous here means a 2-second animation, correct?
Labels: M-61
Labels: -Pri-3 Pri-2
Cc: jamescook@chromium.org
We agreed in the meeting to change it from 2 seconds down to 1 second.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f66f4a7c5941784cbfd8600cc36671218ef6c1d

commit 0f66f4a7c5941784cbfd8600cc36671218ef6c1d
Author: afakhry <afakhry@chromium.org>
Date: Fri Jun 30 18:38:01 2017

[Night Light] CL11: Enhancements

Implement requested enhancements by UI review:
- Make short animation duration = 1 second.
- Reduce expanded knob scale to 125%.
- Prevent label bubbles from touching.
- Reduce label bubble and knob distance.
- Add a cubic-bezier label-bubble overlap animation.
- Make knobs snap distance = 60 minutes.

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c28

BUG=705816, 738101 , 738102 , 736875 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2969473004
Cr-Commit-Position: refs/heads/master@{#483774}

[modify] https://crrev.com/0f66f4a7c5941784cbfd8600cc36671218ef6c1d/ash/system/night_light/night_light_controller.cc
[modify] https://crrev.com/0f66f4a7c5941784cbfd8600cc36671218ef6c1d/chrome/browser/resources/settings/device_page/night_light_slider.html
[modify] https://crrev.com/0f66f4a7c5941784cbfd8600cc36671218ef6c1d/chrome/browser/resources/settings/device_page/night_light_slider.js

Status: Fixed (was: Assigned)
Components: -UI>Shell UI>NightLight
Status: Verified (was: Fixed)
10146.0.0, 64.0.3272.0

Sign in to add a comment