No integration tests check that SetURLRequestContextForNSSHttpIO is called |
||
Issue descriptionI accidentally removed the call to SetURLRequestContextForNSSHttpIO in https://codereview.chromium.org/2929153002. The change was missed because I stopped using the SYstemURLRequestContext class, but forgot to delete it, and no tests failed. Surely if we depend on this being hooked up, we should have a browser test that covers this? Marking this P1, because given the whole servicification thing, this *will* inevitably break again, without tests.
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e14d8f6b14aae2ab3883ea0f4483b33caadd5086 commit e14d8f6b14aae2ab3883ea0f4483b33caadd5086 Author: Matt Mueller <mattm@chromium.org> Date: Wed Jun 28 04:44:21 2017 Add browser_tests of OCSP fetching. Bug: 736866 Change-Id: Ib4e5ab4affd3567db8c7796f6713931bf687dfd9 Reviewed-on: https://chromium-review.googlesource.com/550918 Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#482882} [modify] https://crrev.com/e14d8f6b14aae2ab3883ea0f4483b33caadd5086/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/e14d8f6b14aae2ab3883ea0f4483b33caadd5086/net/test/spawned_test_server/base_test_server.cc
,
Jun 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mattm@chromium.org
, Jun 26 2017Status: Assigned (was: Untriaged)