New issue
Advanced search Search tips

Issue 736859 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug
Proj-Servicification



Sign in to add a comment

SetURLRequestContextForNSSHttpIO no longer called, rendering linux OSCP non-functional since 61.0.3132.0

Project Member Reported by mattm@chromium.org, Jun 26 2017 
r14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3 changed how system url request context is created, so SetURLRequestContextForNSSHttpIO is no longer called.

Repro: Load https://www.paypal.com

Expected:
* URL bar shows EV info
* No error logs.

Actual:
* URL bar shows "Secure"
* ERROR logs get printed, ex:
[34694:35662:0626/115220.935184:ERROR:nss_ocsp.cc(613)] No URLRequestContext for NSS HTTP handler. host: s2.symcb.com
[34694:35662:0626/115220.935209:ERROR:nss_ocsp.cc(613)] No URLRequestContext for NSS HTTP handler. host: s1.symcb.com

Comment 1 by mmenke@chromium.org, Jun 26 2017

Cc: mmenke@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't work on cert code, and have no clue what this has to do the the network service.  So it makes no sense at all to assign this to me.

Comment 2 by mattm@chromium.org, Jun 26 2017 

Did you miss the first line?

"r14085ad54d50252bcadd1b1d7dc4a0bca2c9c5b3 changed how system url request context is created, so SetURLRequestContextForNSSHttpIO is no longer called."

Comment 3 by mmenke@chromium.org, Jun 26 2017

Cc: -mmenke@chromium.org
Owner: mmenke@chromium.org
Status: Assigned (was: Available)
Sorry, I have a strange inability to map a random sequence of characters to anything meaningful.

Comment 4 by mmenke@chromium.org, Jun 26 2017 

Who owns the cert code?  The fact that we have no browser test that depends on this seems like a bug.

Comment 5 by mattm@chromium.org, Jun 26 2017 

I am one of the owners. Yeah, we really should have a test, though these things can be tricky to test. I can take a look at that.

Comment 6 by mmenke@chromium.org, Jun 26 2017 

I filed bugs for both removed calls (The NSS one and the Android one that does basically the same thing).  I'd attempt to add tests myself, but don't know the code at all.

I do intend to add integration tests for features as I move setup of features over to the NetworkService side of things, but that only applies to things I actually understand.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dcfb51eaa0aa79a8f92b6e0db1486cee1119fcd

commit 4dcfb51eaa0aa79a8f92b6e0db1486cee1119fcd
Author: mmenke <mmenke@chromium.org>
Date: Mon Jun 26 22:00:21 2017

Restore calls to set cert fetcher on some platforms.

https://codereview.chromium.org/2929153002 accidentally removed the
calls when it switch URLRequestContext creation over to using
URLRequestContextBuilder. Since no tests rely on these two calls, the
breakage was not caught by tests.

BUG= 736859 

Review-Url: https://codereview.chromium.org/2960713002
Cr-Commit-Position: refs/heads/master@{#482428}

[modify] https://crrev.com/4dcfb51eaa0aa79a8f92b6e0db1486cee1119fcd/chrome/browser/io_thread.cc

Comment 8 by mmenke@chromium.org, Jun 26 2017

Status: Fixed (was: Assigned)

Comment 9 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
►

Sign in to add a comment