New issue
Advanced search Search tips

Issue 736858 link

Starred by 1 user
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713889



Sign in to add a comment

color: tab capture browser_tests fail with --enable-features=ColorCorrectRendering

Project Member Reported by ccameron@chromium.org, Jun 26 2017 
This failed in a test run of changing the default state of the flag at
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/487392

The failures were

  CastStreamingApiTestWithPixelOutput.EndToEnd
  TabCaptureApiPixelTest.EndToEndWithoutRemoting

This can be reproduced on linux by using a non-SRGB color profile (e.g, by calling "xicc /usr/share/color/icc/colord/AdobeRGB1998.icc" beforehand). The test does pass when using an sRGB color profile

In theory this test should be using --force-display-color-profile, like all other browser tests do, via the changes in crrev.com/480741. Somehow this isn't taking.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b037d8aeab84570a38de96ea8a7f4fe314f8e5a1

commit b037d8aeab84570a38de96ea8a7f4fe314f8e5a1
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Jun 26 22:50:08 2017

color: Force an sRGB color space for in-process browser tests

The results of these tests should not depend on the color profile of
the monitor that happens to be attached to the system. This flag
makes the tests ignore that profile and always use an sRGB color
profile (which is what the tests had been assuming all along).

This was done for not-in-process browser tests in crrev.com/480741, but
was not applied to in-process browser tests in that patch.

Bug:  736858 
Change-Id: Ia849301d9077e587ee2dd499585d766900d18ac3
Reviewed-on: https://chromium-review.googlesource.com/549136
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482443}
[modify] https://crrev.com/b037d8aeab84570a38de96ea8a7f4fe314f8e5a1/chrome/test/base/in_process_browser_test.cc

Comment 2 by ccameron@chromium.org, Jun 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment