Night Light: update the Tool Tip to indicate Night Light On/Off state |
|||||
Issue descriptionCurrently Night Light tool tip lists Night light in sentence case, instead should list it in Title Case. Also Night Light tool tip should indicate the state ON/OFF: when Night Light is on tooltip to state: Night Light is On when Night Light is off tooltip to state: Night Light is Off thanks! Olga
,
Jun 29 2017
,
Jun 29 2017
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e955e728e2a1ed9225ab13d2751b07eff7d291b4 commit e955e728e2a1ed9225ab13d2751b07eff7d291b4 Author: afakhry <afakhry@chromium.org> Date: Thu Jul 06 00:21:42 2017 [Night Light] CL12: String changes and fix frequent requests. - Implement requests to change the tooltip text of the tray Night Light button to "Night Light: On/Off". - Fix changing the schedule type to "sunset to sunrise" triggering a new geoposition request every time. - Add OWNERS. BUG= 736856 ,705816 Review-Url: https://codereview.chromium.org/2966873002 Cr-Commit-Position: refs/heads/master@{#484406} [modify] https://crrev.com/e955e728e2a1ed9225ab13d2751b07eff7d291b4/ash/ash_strings.grd [add] https://crrev.com/e955e728e2a1ed9225ab13d2751b07eff7d291b4/ash/system/night_light/OWNERS [modify] https://crrev.com/e955e728e2a1ed9225ab13d2751b07eff7d291b4/ash/system/night_light/night_light_toggle_button.cc [add] https://crrev.com/e955e728e2a1ed9225ab13d2751b07eff7d291b4/chrome/browser/chromeos/night_light/OWNERS [modify] https://crrev.com/e955e728e2a1ed9225ab13d2751b07eff7d291b4/chrome/browser/chromeos/night_light/night_light_client.cc [modify] https://crrev.com/e955e728e2a1ed9225ab13d2751b07eff7d291b4/chrome/browser/chromeos/night_light/night_light_client.h [modify] https://crrev.com/e955e728e2a1ed9225ab13d2751b07eff7d291b4/chrome/browser/chromeos/night_light/night_light_client_unittest.cc
,
Jul 6 2017
,
Nov 21 2017
10146.0.0, 64.0.3272.0 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by afakhry@chromium.org
, Jun 29 2017