New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736821 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

ec: Support RT9467 battery charger

Project Member Reported by philipchen@chromium.org, Jun 26 2017

Issue description

We'll need a charger driver for RT9467 soon. 
 
Summary: ec: Support RT9467 battery charger (was: Support RT9467 battery charger)
Labels: OS-Chrome
Owner: philipchen@chromium.org

Comment 4 by caveh@chromium.org, Jul 10 2017

Labels: -Type-Bug Type-Feature
please provide actionable details in your request.
what does "soon" mean?
which platform(s)?

It's mainly for project Scarlet.
I don't what to disclose too much detail here, but you can find the schedule at:
https://docs.google.com/spreadsheets/d/172BpS-zZoDt6WygxVtCrm85ErYoUhVkKFm8F9j68WcQ/edit

Actually I'm already working on the driver for rt946x:
https://chromium-review.googlesource.com/#/c/565055/
Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/0cd2d2f1034c2bb8dbe2f23d5c2e8340c90cd321

commit 0cd2d2f1034c2bb8dbe2f23d5c2e8340c90cd321
Author: Philip Chen <philipchen@google.com>
Date: Thu Jul 13 07:48:18 2017

charger/rt946x: add Richtek rt946x charger driver

BUG= chromium:736821 
BRANCH=none
TEST=
1) add RT9467 config to Scarlet and build the code
2) hook up rt9467 eval board with dummy load
3) verify the i2c traffic: set voltage, set current, and
   get device id

Change-Id: Ie0dc2650711465b89eb4a5fbf69a326d6277b583
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/565055
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>

[add] https://crrev.com/0cd2d2f1034c2bb8dbe2f23d5c2e8340c90cd321/driver/charger/rt946x.c
[add] https://crrev.com/0cd2d2f1034c2bb8dbe2f23d5c2e8340c90cd321/driver/charger/rt946x.h
[modify] https://crrev.com/0cd2d2f1034c2bb8dbe2f23d5c2e8340c90cd321/driver/build.mk
[modify] https://crrev.com/0cd2d2f1034c2bb8dbe2f23d5c2e8340c90cd321/include/config.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/381fc5912c6b528c5dbc4509feeade07a1332694

commit 381fc5912c6b528c5dbc4509feeade07a1332694
Author: Philip Chen <philipchen@google.com>
Date: Thu Jul 27 07:40:48 2017

charger/rt946x: Add chip-specific interface functions

Add rt946x_enable_charger_boost() to
enable/disable rt946x.

Add rt946x_is_vbus_ready() to
check if VBUS is ready.

Add rt946x_cutoff_battery to
cutoff battery.

BUG= chromium:736821 
BRANCH=none
TEST=build scarlet when rt946x driver is used

Change-Id: I61b07ca0925f5ba2c71fe8033a3a496fe00869d9
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/573584
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>

[modify] https://crrev.com/381fc5912c6b528c5dbc4509feeade07a1332694/driver/charger/rt946x.c
[modify] https://crrev.com/381fc5912c6b528c5dbc4509feeade07a1332694/driver/charger/rt946x.h

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/321625dc1144ca3efef715997a09794f9fd3e9fd

commit 321625dc1144ca3efef715997a09794f9fd3e9fd
Author: Philip Chen <philipchen@google.com>
Date: Fri Aug 18 03:41:54 2017

charger/rt946x: Finish init no matter which CHIP REV it is

When booting scarlet rev1, the initialization of rt9466
is not finished because CHIP REV < 0x05.

Actually, we shouldn't keep the latest CHIP REV in rt946x.h
because it's hard to maintain. And we should try to finish
rt946x_init() no matter what CHIP REV it is.

Also, let's clean up the logging message in rt946x_init()
a bit to make it clear that it's from RT946X.

BUG= chromium:736821 , b:63739819
BRANCH=none
TEST=boot scarlet rev1 and confirm the
initialization of rt946x is finished

Change-Id: Ic0b1f837b801cc18744a1222794a055dfe8aa54c
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/612585
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>

[modify] https://crrev.com/321625dc1144ca3efef715997a09794f9fd3e9fd/driver/charger/rt946x.c
[modify] https://crrev.com/321625dc1144ca3efef715997a09794f9fd3e9fd/driver/charger/rt946x.h

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment