New issue
Advanced search Search tips

Issue 736816 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

git cl issue XXXXXXX no longer works for rietveld

Project Member Reported by michae...@chromium.org, Jun 26 2017

Issue description

`git cl issue XXXXXX` no longer sets rietveld issue info, even with `--rietveld`.

it configures a gerrit issue instead.

> git checkout -b FooBar
Switched to a new branch 'FooBar'
> git cl issue 2939833002 --rietveld
Issue number: 2939833002 (https://chromium-review.googlesource.com/2939833002)

> grep -A 2 FooBar .git/config
[branch "FooBar"]
        gerritissue = 2939833002
        gerritserver = https://chromium-review.googlesource.com
 

Comment 1 by aga...@chromium.org, Jun 26 2017

Cc: -aga...@chromium.org
Owner: aga...@chromium.org
Status: Started (was: Untriaged)
Woah, good catch. Fix: https://chromium-review.googlesource.com/c/549060/

Comment 2 by aga...@chromium.org, Jun 26 2017

Components: -Infra>Git Infra>Codereview>Gerrit Infra>SDK
Labels: Milestone-Launch Proj-Gerrit-Migration

Comment 3 by aga...@chromium.org, Jun 26 2017

Labels: -Milestone-Launch Milestone-Turndown
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/aee6c8527222f719c55eb9d3e1dcdd6bcd808e95

commit aee6c8527222f719c55eb9d3e1dcdd6bcd808e95
Author: Aaron Gable <agable@chromium.org>
Date: Tue Jun 27 17:54:24 2017

git-cl-issue: respect --gerrit/--rietveld with integer argument

Bug:  736816 
Change-Id: I56d222a3aad684f51c8c47f302c8a298b7a0469a
Reviewed-on: https://chromium-review.googlesource.com/549060
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/aee6c8527222f719c55eb9d3e1dcdd6bcd808e95/git_cl.py

Comment 5 by aga...@chromium.org, Jun 27 2017

Status: Fix (was: Started)

Comment 6 by aga...@chromium.org, Jun 27 2017

Status: Fixed (was: Fix)

Sign in to add a comment