New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 736791 link

Starred by 1 user
Status: Archived
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
xiy...@chromium.org
weidongg@chromium.org
newcomer@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 735702



Sign in to add a comment

Move StartPageView::StartPageTilesContainer out of StartPageView

Project Member Reported by warx@chromium.org, Jun 26 2017 
StartPageView::StartPageTilesContainer used to hold recommendation app tiles and the all apps button. It used to stay on start launcher page only. For new design, recommendation app tiles are required to show on the all apps page, too.

To reuse the code, consider moving this private nested class to a separate public class. Name can be SuggestedAppsContainerView.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc71d4e0ecab89b4f51f73af9a48f54f342faa0e

commit cc71d4e0ecab89b4f51f73af9a48f54f342faa0e
Author: Qiang Xu <warx@chromium.org>
Date: Tue Jun 27 16:49:00 2017

cros: move StartPageTilesContainer, rename to SuggestionsContainerView

Changes:
(1) mainly a mechanical refactor:
move StartPageView::StartPageTilesContainer out of StartPageView, to
support adding recommendation tiles in STATE_APPS page.
(2) remove AppListViewDelegate ctor parameter.

--enable-features=EnableFullscreenAppList flag, expect no UI change.

R: xiyuan@chromium.org
Bug:  736791 
TEST: tested with and without
Change-Id: I766299d2d19d693a8cf2c6199d147b7e9bb3d4e0
Reviewed-on: https://chromium-review.googlesource.com/548972
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482652}
[modify] https://crrev.com/cc71d4e0ecab89b4f51f73af9a48f54f342faa0e/ui/app_list/BUILD.gn
[modify] https://crrev.com/cc71d4e0ecab89b4f51f73af9a48f54f342faa0e/ui/app_list/views/apps_container_view.h
[modify] https://crrev.com/cc71d4e0ecab89b4f51f73af9a48f54f342faa0e/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/cc71d4e0ecab89b4f51f73af9a48f54f342faa0e/ui/app_list/views/start_page_view.h
[add] https://crrev.com/cc71d4e0ecab89b4f51f73af9a48f54f342faa0e/ui/app_list/views/suggestions_container_view.cc
[add] https://crrev.com/cc71d4e0ecab89b4f51f73af9a48f54f342faa0e/ui/app_list/views/suggestions_container_view.h

Comment 2 by warx@chromium.org, Jun 27 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment