Feature Request: Allow to edit Heap Snapshot names
Reported by
diana.su...@gmail.com,
Jun 26 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3135.0 Safari/537.36 Steps to reproduce the problem: 1. Open DevTools -> Memory Tab 2. Select "Take Heap Snapshot" and click "Take Snapshot" 3. Generated Heap Snapshots appear named "Snapshot 1", "Snapshot 2" etc What is the expected behavior? As one of the flow to debug potential memory leaks, I switch between commits in our repo and take heap snapshots to localize where problem started. At this stage It would be very helpful if I could give snapshots descriptive names for example "Commit#abc123_Try#1" What went wrong? Currently there is no way to change auto-generated names. Did this work before? No Chrome version: 61.0.3135.0 Channel: canary OS Version: OS X 10.12.4 Flash Version:
,
Jun 27 2017
Assuming this as feature request, changing the status to untriage, so that the issue would be addressed. Thank you.
,
Jul 5 2017
,
Jul 5 2017
Hey, I have a PR to address this ticket https://codereview.chromium.org/2954973002/. It's been up for almost a week now and I didn't get any feedback. I'd be happy to work with whoever is assigned to this ticket. Thanks, Diana
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8130390255328a1d6e922d8cfd281304935f556b commit 8130390255328a1d6e922d8cfd281304935f556b Author: diana.suvorova <diana.suvorova@gmail.com> Date: Wed Jul 12 02:19:54 2017 Heap profile usability enhancement. Making it easier to navigate through multiple heap profiles. BUG (rather feature)= 736776 Review-Url: https://codereview.chromium.org/2954973002 Cr-Commit-Position: refs/heads/master@{#485798} [modify] https://crrev.com/8130390255328a1d6e922d8cfd281304935f556b/AUTHORS [modify] https://crrev.com/8130390255328a1d6e922d8cfd281304935f556b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js [modify] https://crrev.com/8130390255328a1d6e922d8cfd281304935f556b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileHeader.js [modify] https://crrev.com/8130390255328a1d6e922d8cfd281304935f556b/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js
,
Jul 13 2017
Thanks to Diana for implementing it! |
||||
►
Sign in to add a comment |
||||
Comment 1 by diana.su...@gmail.com
, Jun 26 2017