ui::PAGE_TRANSITION_FORWARD_BACK dropped during navigations. |
||||
Issue descriptionFor some back/forward navigations, the page transition qualifier: ui::PAGE_TRANSITION_FORWARD_BACK is sometimes dropped. What it means is that: * In NavigationHandleImpl::WillStartRequest() transition & ui::PAGE_TRANSITION_FORWARD_BACK is true. * In NavigationHandleImpl::DidCommitNavigation() params.transition & ui::PAGE_TRANSITION_FORWARD_BACK is false. This CL shows in which tests ui::PAGE_TRANSITION_FORWARD_BACK is dropped: https://codereview.chromium.org/2958573002/
,
Jun 29 2017
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b757c63d2e76e4ea078e3ca4ca873d5b594073ea commit b757c63d2e76e4ea078e3ca4ca873d5b594073ea Author: arthursonzogni <arthursonzogni@chromium.org> Date: Mon Jul 10 16:16:14 2017 PageTransition: Remove unreached code. Remove a block of code that used to detect a incorrect PageTransition and to replace it by its correct value. Apparently, this block is no more reached. This CL removes it. Furthermore, a test is added. It replays the steps one had to do to reach this block of code. BUG=736772,740461 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2961903003 Cr-Commit-Position: refs/heads/master@{#485287} [modify] https://crrev.com/b757c63d2e76e4ea078e3ca4ca873d5b594073ea/content/browser/frame_host/navigation_controller_impl_browsertest.cc [modify] https://crrev.com/b757c63d2e76e4ea078e3ca4ca873d5b594073ea/content/renderer/render_frame_impl.cc
,
Jul 11
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12
I still have the CL that checks when PAGE_TRANSITION_FORWARD_BACK is dropped: https://bugs.chromium.org/p/chromium/issues/detail?id=736772#c4 I run it again, the DCHECK is still reached in a bunch of tests: https://ci.chromium.org/buildbot/tryserver.chromium.linux/cast_shell_linux/535669 This is low priority, so I am not going to spend time on it. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jun 27 2017