New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736772 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ui::PAGE_TRANSITION_FORWARD_BACK dropped during navigations.

Project Member Reported by arthurso...@chromium.org, Jun 26 2017

Issue description

For some back/forward navigations, the page transition qualifier: ui::PAGE_TRANSITION_FORWARD_BACK is sometimes dropped.

What it means is that:
* In NavigationHandleImpl::WillStartRequest()
  transition & ui::PAGE_TRANSITION_FORWARD_BACK is true.

* In NavigationHandleImpl::DidCommitNavigation()
  params.transition & ui::PAGE_TRANSITION_FORWARD_BACK is false.

This CL shows in which tests ui::PAGE_TRANSITION_FORWARD_BACK is dropped:
https://codereview.chromium.org/2958573002/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2504f838819d321e4bf62e3da29ec258260356e3

commit 2504f838819d321e4bf62e3da29ec258260356e3
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Tue Jun 27 09:18:56 2017

Fix wrong ui::PAGE_TRANSITION_FORWARD_BACK in tests.

This CL modify some unit tests such that the PageTransition qualifier:
ui::PAGE_TRANSITION_FORWARD_BACK matches when the browser askes for a
new navigation and the renderer navigates.

Context: https://crrev.com/2958573002/
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

BUG=736772

Review-Url: https://codereview.chromium.org/2957783002
Cr-Commit-Position: refs/heads/master@{#482581}

[modify] https://crrev.com/2504f838819d321e4bf62e3da29ec258260356e3/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/2504f838819d321e4bf62e3da29ec258260356e3/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/2504f838819d321e4bf62e3da29ec258260356e3/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
[modify] https://crrev.com/2504f838819d321e4bf62e3da29ec258260356e3/content/browser/web_contents/web_contents_impl_unittest.cc

Labels: -OS-Fuchsia
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b757c63d2e76e4ea078e3ca4ca873d5b594073ea

commit b757c63d2e76e4ea078e3ca4ca873d5b594073ea
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Mon Jul 10 16:16:14 2017

PageTransition: Remove unreached code.

Remove a block of code that used to detect a incorrect PageTransition
and to replace it by its correct value.
Apparently, this block is no more reached. This CL removes it.
Furthermore, a test is added. It replays the steps one had to do to
reach this block of code.

BUG=736772,740461
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2961903003
Cr-Commit-Position: refs/heads/master@{#485287}

[modify] https://crrev.com/b757c63d2e76e4ea078e3ca4ca873d5b594073ea/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/b757c63d2e76e4ea078e3ca4ca873d5b594073ea/content/renderer/render_frame_impl.cc

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: arthurso...@chromium.org
Labels: -Pri-2 -Hotlist-Recharge-Cold Pri-3
Owner: ----
Status: Available (was: Untriaged)
I still have the CL that checks when PAGE_TRANSITION_FORWARD_BACK is dropped:
https://bugs.chromium.org/p/chromium/issues/detail?id=736772#c4

I run it again, the DCHECK is still reached in a bunch of tests:
https://ci.chromium.org/buildbot/tryserver.chromium.linux/cast_shell_linux/535669

This is low priority, so I am not going to spend time on it.

Sign in to add a comment