WebViewInteractiveTests/WebViewImeInteractiveTest.CompositionRangeUpdates/0 is very flaky on Mac |
|||
Issue descriptionPlease refer to the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_side_navigation_interactive_ui_tests&tests=WebViewImeInteractiveTest.CompositionRangeUpdates ekaramad@: I found that this test is recently changed by you, could you take a look.
,
Jun 26 2017
I have a CL in progress: https://chromium-review.googlesource.com/c/545223/
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/090e405d8593f529416c11b589134ab4b7232554 commit 090e405d8593f529416c11b589134ab4b7232554 Author: Xida Chen <xidachen@chromium.org> Date: Thu Jun 29 01:29:21 2017 [Follow up] Disable flaky test ... testWebViewInteractiveTests/WebViewImeInteractiveTest.CompositionRangeUpdates/0 on Mac I made a mistake in a previous CL here: https://chromium-review.googlesource.com/c/548835/ This CL disable it for real. TBR=ekaramad@chromium.org NOTRY=true Bug: 736759 Change-Id: I03fe74fae7f6da36fc15c8caebf5195c8ea476f7 Reviewed-on: https://chromium-review.googlesource.com/553499 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#483242} [modify] https://crrev.com/090e405d8593f529416c11b589134ab4b7232554/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b933c4942b1f9f74cef4d563c49fb82b3c4795da commit b933c4942b1f9f74cef4d563c49fb82b3c4795da Author: Ehsan Karamad <ekaramad@chromium.org> Date: Thu Jul 13 17:23:52 2017 Fix an issue in WebViewImeInteractiveTest.CompositionRangeUpdates. We need to properly clear CompositionRangeUpdateObserver used in the test body and do not rely on tear down process. There seems to be a bug in the internals of TextInputManagerTester where the internal observer is not properly removed from TextInputManager's observer list. Synthetic local testing shows that if we repeatedly pump RenderWidget::UpdateCompositionInfo(true), the test crashes in non-OOPIF mode. The reasons seems to be that TextInputManagerTester::observer_ is not removed from TextInputManager's observer list and a late arriving IPC for IME composition range during shutdown causes the test process to crash (UaF). BUG= 736759 , 602723 Change-Id: Iebf1f20dccddae63ad587ec6f03bf6951b89c5ee Reviewed-on: https://chromium-review.googlesource.com/545223 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486425} [modify] https://crrev.com/b933c4942b1f9f74cef4d563c49fb82b3c4795da/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc [modify] https://crrev.com/b933c4942b1f9f74cef4d563c49fb82b3c4795da/content/public/test/text_input_test_utils.cc
,
Nov 7 2017
Marking as fixed following comment #4.
,
Feb 13 2018
Actually marking as fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 26 2017