New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736750 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 737493



Sign in to add a comment

Diagnostic commands for Atrus firmware v0.8.0

Project Member Reported by lndmrk@chromium.org, Jun 26 2017

Issue description

Add diagnostic commands 0x1807 and 0x1814-0x181E to atrusctl.
 

Comment 1 by lndmrk@chromium.org, Jun 28 2017

Blockedon: 737493

Comment 2 by lndmrk@chromium.org, Jun 28 2017

Cc: deborahliu@chromium.org
Components: OS>Kernel>Audio>USB
Labels: -Restrict-View-Google

Comment 3 by lndmrk@chromium.org, Jun 28 2017

Cc: k...@limesaudio.com
The commands 0x181B-0x181E (DIAGNOSTIC_COMMAND_TV_GAMMA_MIN-DIAGNOSTIC_COMMAND_TV_GAMMA_VARIANCE) will not be implemented in 0.8.0 and should not be ask for.

Comment 5 by lndmrk@chromium.org, Jul 14 2017

Cc: sadolfsson@google.com

Comment 6 by lndmrk@chromium.org, Jul 25 2017

Labels: Proj-Bluestreak
Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/atrusctl/+/84aa746ad34df59cd138c35aa98332bae642cecb

commit 84aa746ad34df59cd138c35aa98332bae642cecb
Author: Emil Lundmark <lndmrk@chromium.org>
Date: Mon Aug 07 18:45:04 2017

Add diagnostic commands for firmware v0.8.0

This adds some new diagnostic commands that where implemented in
firmware v0.8.0.

BUG= chromium:736750 
TEST=Connected an Atrus device with firmware v0.8.0 and verified that
the new diagnostics where logged to /var/log/atrus.log

Change-Id: I7e0a5b38e4037ecef08f1ca4480cfae81040596f
Reviewed-on: https://chromium-review.googlesource.com/571752
Commit-Ready: Emil Lundmark <lndmrk@chromium.org>
Tested-by: Emil Lundmark <lndmrk@chromium.org>
Reviewed-by: Simon Que <sque@chromium.org>

[modify] https://crrev.com/84aa746ad34df59cd138c35aa98332bae642cecb/src/diagnostics.cc

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment