New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 736745 link

Starred by 2 users
Status: Fixed
Owner:
jinho.b...@samsung.com
Closed: Sep 2017
Cc:
█ zkoch@chromium.org
rouslan@chromium.org
gogerald@chromium.org
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 661608


Participants' hotlists:
Payment-Handler


Sign in to add a comment

Implement CanMakePaymentEvent and AbortPaymentEvent.

Project Member Reported by jinho.b...@samsung.com, Jun 26 2017 
We need a way to delegate canMakePayment() and abort()-including UI aborted from PaymentRequest to PaymentHandler.
Rouslan already has sent a pull request to solve the problem.
  - https://github.com/w3c/payment-handler/pull/170
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e

commit 871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e
Author: jinho.bang <jinho.bang@samsung.com>
Date: Thu Jul 06 17:19:44 2017

PaymentHandler: Add Interfaces for CanMakePaymentEvent.

This is an initial implementation of CanMakePaymentEvent in WebIDL level.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

See the other CLs in this series:
  [1/4] This patch.
  [2/4] https://chromium-review.googlesource.com/c/558888
  [3/4] https://chromium-review.googlesource.com/c/558889
  [4/4] https://chromium-review.googlesource.com/c/558890

Bug:  736745 
Change-Id: I4fbb83d5c7ee014bfe773e4b246d1bf56e4dd0f8
Reviewed-on: https://chromium-review.googlesource.com/558887
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484646}
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/core/events/EventTypeNames.json5
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/modules/payments/BUILD.gn
[add] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/modules/payments/CanMakePaymentEvent.cpp
[add] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/modules/payments/CanMakePaymentEvent.h
[add] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/modules/payments/CanMakePaymentEvent.idl
[add] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/modules/payments/CanMakePaymentEventInit.idl
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerGlobalScope.h
[modify] https://crrev.com/871c0a37b06b2c7ef0ba708eebf62d06d32d7d9e/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerGlobalScope.idl
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae83c1b80e6deb2f58fd752ee240442f2d46bb33

commit ae83c1b80e6deb2f58fd752ee240442f2d46bb33
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jul 06 20:53:33 2017

PaymentHandler: Add WebCanMakePaymentEventData and ToCanMakePaymentEventInit().

The WebCanMakePaymentEventData is exposed to Content layer to receive merchant
information that initialized payment request. Also, ToCanMakePaymentEventInit()
method is used to convert the WebCanMakePaymentEventData to
CanMakePaymentEventInit.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

See the other CLs in this series:
  [1/4] https://chromium-review.googlesource.com/c/558887
  [2/4] This patch.
  [3/4] https://chromium-review.googlesource.com/c/558889
  [4/4] https://chromium-review.googlesource.com/c/558890

Bug:  736745 
Change-Id: I97a8b013a8c1b39c0f484ee7eb72896e0c1f0492
Reviewed-on: https://chromium-review.googlesource.com/558888
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484737}
[modify] https://crrev.com/ae83c1b80e6deb2f58fd752ee240442f2d46bb33/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/ae83c1b80e6deb2f58fd752ee240442f2d46bb33/third_party/WebKit/Source/modules/payments/BUILD.gn
[rename] https://crrev.com/ae83c1b80e6deb2f58fd752ee240442f2d46bb33/third_party/WebKit/Source/modules/payments/PaymentEventDataConversion.cpp
[add] https://crrev.com/ae83c1b80e6deb2f58fd752ee240442f2d46bb33/third_party/WebKit/Source/modules/payments/PaymentEventDataConversion.h
[rename] https://crrev.com/ae83c1b80e6deb2f58fd752ee240442f2d46bb33/third_party/WebKit/Source/modules/payments/PaymentEventDataConversionTest.cpp
[delete] https://crrev.com/bee510c1c0e3fbd1e6ba6c79ca822d260268ee72/third_party/WebKit/Source/modules/payments/PaymentRequestEventDataConversion.h
[modify] https://crrev.com/ae83c1b80e6deb2f58fd752ee240442f2d46bb33/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[add] https://crrev.com/ae83c1b80e6deb2f58fd752ee240442f2d46bb33/third_party/WebKit/public/platform/modules/payments/WebCanMakePaymentEventData.h
[modify] https://crrev.com/ae83c1b80e6deb2f58fd752ee240442f2d46bb33/third_party/WebKit/public/platform/modules/payments/WebPaymentRequestEventData.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5db744c4d6512020d82b932f35a76634a5b0804

commit d5db744c4d6512020d82b932f35a76634a5b0804
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jul 10 09:53:32 2017

PaymentHandler: Add CanMakePaymentRespondWithObserver.

Add CanMakePaymentRespondWithObserver to Blink. The class is used for processing
result promise of respondWith() in |canmakepayment| event.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

See the other CLs in this series:
  [1/4] https://chromium-review.googlesource.com/c/558887
  [2/4] https://chromium-review.googlesource.com/c/558888
  [3/4] This patch.
  [4/4] https://chromium-review.googlesource.com/c/558890

Bug:  736745 
Change-Id: I74782f924d67cc5cb732dd6797d40b76116f372f
Reviewed-on: https://chromium-review.googlesource.com/558889
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485218}
[modify] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/payments/BUILD.gn
[add] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/payments/CanMakePaymentRespondWithObserver.cpp
[add] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/payments/CanMakePaymentRespondWithObserver.h
[add] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/payments/PaymentHandlerUtils.cpp
[add] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/payments/PaymentHandlerUtils.h
[modify] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/payments/PaymentRequestRespondWithObserver.cpp
[modify] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/payments/PaymentRequestRespondWithObserver.h
[modify] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
[modify] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/d5db744c4d6512020d82b932f35a76634a5b0804/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2936213529bc3f1b47565f18eb07e1ff65f4ed4e

commit 2936213529bc3f1b47565f18eb07e1ff65f4ed4e
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jul 10 11:51:06 2017

PaymentHandler: Expose CanMakePaymentEvent to content.

This change is finishing implementing CanMakePaymentEvent in Blink side.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

See the other CLs in this series:
  [1/4] https://chromium-review.googlesource.com/c/558887
  [2/4] https://chromium-review.googlesource.com/c/558888
  [3/4] https://chromium-review.googlesource.com/c/558889
  [4/4] This patch.

Bug:  736745 
Change-Id: Ie2d54af80a84da8654204c9b7d183469e958df12
Reviewed-on: https://chromium-review.googlesource.com/558890
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485238}
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
[modify] https://crrev.com/2936213529bc3f1b47565f18eb07e1ff65f4ed4e/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e

commit 2d1d3d0ab6b476eff0d2b77c11426211d1fad63e
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Jul 18 14:05:53 2017

PaymentHandler: Add Interfaces for AbortPaymentEvent.

This is an initial implementation of AbortPaymentEvent in WebIDL level.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

Bug:  736745 
Change-Id: I5cdf6b8e6a8019121aed4e10d33e884076bb519b
Reviewed-on: https://chromium-review.googlesource.com/571345
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487463}
[add] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/LayoutTests/http/tests/payments/abort-payment-event.html
[add] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/LayoutTests/http/tests/payments/resources/abort-payment-event.js
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/core/events/EventTypeNames.json5
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/modules/modules_idl_files.gni
[add] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/modules/payments/AbortPaymentEvent.cpp
[add] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/modules/payments/AbortPaymentEvent.h
[add] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/modules/payments/AbortPaymentEvent.idl
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/modules/payments/BUILD.gn
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerGlobalScope.h
[modify] https://crrev.com/2d1d3d0ab6b476eff0d2b77c11426211d1fad63e/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerGlobalScope.idl
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0142ea0c65cdb5cbc465de425adb5b8572d62ab7

commit 0142ea0c65cdb5cbc465de425adb5b8572d62ab7
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Jul 25 20:12:32 2017

PaymentHandler: Implement AbortPaymentEvent in blink side.

The AbortPaymentEvent is used to attempt to abort a payment request in progress.
It has respondWith() method that is used by payment handler to indicate whether
it was able to abort the payment.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

Bug:  736745 
Change-Id: I9cee5468cba6d89bdfbc24e812f8694bbed27fad
Reviewed-on: https://chromium-review.googlesource.com/572605
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489410}
[add] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/payments/AbortPaymentRespondWithObserver.cpp
[add] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/payments/AbortPaymentRespondWithObserver.h
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/payments/BUILD.gn
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
[modify] https://crrev.com/0142ea0c65cdb5cbc465de425adb5b8572d62ab7/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/906140018de23cd379b1f8c44ac5576593de8ee5

commit 906140018de23cd379b1f8c44ac5576593de8ee5
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Aug 02 00:17:07 2017

PaymentHandler: Implement CanMakePaymentEvent in content side.

The CanMakePaymentEvent is used to check whether the payment handler is able to
respond to a payment request.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

Bug:  736745 
Test: payment_app_provider_impl_unittest.cc, payment_app_browsertest.cc
Change-Id: Ib4073d26fd8e24e1bcbf1b113c3fd3fd3451c609
Reviewed-on: https://chromium-review.googlesource.com/574992
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491163}
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/payments/payment_app_browsertest.cc
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/payments/payment_app_provider_impl.h
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/payments/payment_app_provider_impl_unittest.cc
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/public/browser/payment_app_provider.h
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/renderer/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/content/test/data/payments/payment_app.js
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/third_party/WebKit/public/platform/modules/payments/payment_app.mojom
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/906140018de23cd379b1f8c44ac5576593de8ee5/tools/metrics/histograms/histograms.xml
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b

commit 22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Aug 09 19:11:51 2017

PaymentHandler: Implement AbortPaymentEvent in content side.

The AbortPaymentEvent is used to attempt to abort a payment request in progress.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

Bug:  736745 
Test: payment_app_provider_impl_unittest.cc, payment_app_browsertest.cc
Change-Id: I7bbec0cb362c98c7c25518edf405a1a5a96241b9
Reviewed-on: https://chromium-review.googlesource.com/600748
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#493087}
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/payments/payment_app_browsertest.cc
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/payments/payment_app_provider_impl.h
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/payments/payment_app_provider_impl_unittest.cc
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/service_worker/browser_side_service_worker_event_dispatcher.cc
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/service_worker/browser_side_service_worker_event_dispatcher.h
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/public/browser/payment_app_provider.h
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/content/test/data/payments/payment_app.js
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/third_party/WebKit/public/platform/modules/payments/payment_app.mojom
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/22ff05c7b4e962b6486f0a1aa4c4f80f7b26d45b/tools/metrics/histograms/histograms.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cea359402fa83e048b585a89c3de33cae78daae

commit 8cea359402fa83e048b585a89c3de33cae78daae
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Fri Sep 01 23:34:52 2017

PaymentHandler: Implement CanMakePaymentEvent on Android.

The CanMakePaymentEvent is used to check whether the payment handler
is able to respond to a payment request.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

Bug:  736745 
Change-Id: I6333b18291e58f650885e65195c52602c3fe54de
Reviewed-on: https://chromium-review.googlesource.com/637044
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499339}
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
[modify] https://crrev.com/8cea359402fa83e048b585a89c3de33cae78daae/chrome/browser/android/payments/service_worker_payment_app_bridge.cc

Comment 11 by rouslan@chromium.org, Sep 13 2017 

Need to make these events optional.

Comment 12 by jinho.b...@samsung.com, Sep 13 2017 

@rouslan,

What does your comment means?
If my understanding is correct, you want that respondWith(true) if there is no event handler, right?

Comment 13 by rouslan@chromium.org, Sep 14 2017 

> respondWith(true) if there is no event handler.

That is correct for CanMakePayment event. As for AbortPayment event, we want respondWith(false) by default.

Comment 14 by jinho.b...@samsung.com, Sep 15 2017 

@rouslan,

Okay, thank you for your answer.
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a43791e48c2299e7a5a63f923e744f5d053d17c

commit 2a43791e48c2299e7a5a63f923e744f5d053d17c
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Sep 18 13:36:28 2017

PaymentHandler: Make the CanMakePaymentEvent optional.

Bug:  736745 
Change-Id: Icb68c1ffeb5b6d539834d91d54f2aea50a373b61
Reviewed-on: https://chromium-review.googlesource.com/670203
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502566}
[modify] https://crrev.com/2a43791e48c2299e7a5a63f923e744f5d053d17c/third_party/WebKit/Source/modules/payments/CanMakePaymentRespondWithObserver.cpp

Comment 16 by jinho.b...@samsung.com, Sep 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment