New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736738 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

MetricsMediator -setAppGroupMetricsEnabled: is never called

Project Member Reported by sdefresne@chromium.org, Jun 26 2017

Issue description

This method enables collecting logs from application extensions and sending them to UMA. As it is never called, the logs from application extensions are never processed.

This method should either be called when UMA log reporting is enabled on the main application or all the code to transfer logs from application extensions to the main application should be removed (i.e. chrome/common/app_group/app_group_metrics_mainapp.* and ios/chrome/common/app_group/app_group_metrics_client.*).

Leaving as untriaged as I think owner is olivierrobin who is still OOO.
 
+marq as OWNERS of ios/chrome/app/application_delegate/metrics_mediator.mm.

Sample CL that remove the method and the code from ios/schrome/common/app_group that can be considered dead if this -setAppGroupMetricsEnabled: is never invoked with YES can be seen here: https://chromium-review.googlesource.com/c/548376/
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec1c83b78b23f716c09f731c8b395b4ead5d1a81

commit ec1c83b78b23f716c09f731c8b395b4ead5d1a81
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Wed Jun 28 13:48:37 2017

Enable logging app extensions metrics.

Call MetricsMediator -setAppGroupMetricsEnabled: when the metrics
state changes. This ensure that the metrics from the application
extensions are uploaded if metrics reporting is enabled by user.

Bug:  736738 
Change-Id: I4437cff6641d543b44d8a48b4667ddb8afdbcec4
Reviewed-on: https://chromium-review.googlesource.com/550038
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482969}
[modify] https://crrev.com/ec1c83b78b23f716c09f731c8b395b4ead5d1a81/ios/chrome/app/application_delegate/metrics_mediator.mm

Comment 3 by sczs@chromium.org, Jun 28 2017

Owner: sdefresne@chromium.org
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)

Sign in to add a comment